Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: support mainProgram in meta #120692

Merged
merged 1 commit into from
Apr 26, 2021
Merged

stdenv: support mainProgram in meta #120692

merged 1 commit into from
Apr 26, 2021

Conversation

Hoverbear
Copy link
Contributor

Motivation for this change

Support mainProgram as an attribute of meta for packages.

This is an attribute used by nix run to customize the main program of a package.

For example, pkgs.neovim provides a /bin/nvim executable which users would (almost certainly) prefer nix run to execute instead of a non-existing /bin/neovim.

This was recommended by @grahamc in #120662, and it requires this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Hoverbear
stdenv: support mainProgram in meta
acfddd5 
Support `mainProgram` as an attribute of `meta` for packages.

This is an attribute used by [`nix
run`](https://nixos.org/manual/nix/unstable/command-ref/new-cli/nix3-run.html#description)
to customize the main program of a package.

For example, `pkgs.neovim` provides a `/bin/nvim` executable which users
would (almost certainly) prefer `nix run` to execute instead of a
non-existing `/bin/neovim`.

Signed-off-by: Ana Hobden <operator@hoverbear.org>
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Apr 26, 2021
@Hoverbear Hoverbear mentioned this pull request Apr 26, 2021
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 26, 2021
@grahamc grahamc merged commit dd4c01b into NixOS:master Apr 26, 2021
@grahamc
Copy link
Member

grahamc commented Apr 26, 2021

Thanks!

@Hoverbear Hoverbear mentioned this pull request Apr 27, 2021
Merged
10 tasks
@deliciouslytyped deliciouslytyped mentioned this pull request Jun 21, 2021
Open
@siraben siraben mentioned this pull request Jul 3, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @grahamc