Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mwoauth: remve restriction PyJWT < 2.0.0 #122173

Closed
wants to merge 1 commit into from
Closed

python3Packages.mwoauth: remve restriction PyJWT < 2.0.0 #122173

wants to merge 1 commit into from

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented May 8, 2021 •
edited

ZHF: #122042

According to an open PR on their github the library is compatible with PyJWT 2.0 (mediawiki-utilities/python-mwoauth#43)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DavHau
Copy link
Member Author

DavHau commented May 8, 2021

Also enabled tests now

@ofborg ofborg bot requested a review from ixxie May 8, 2021 10:00
@DavHau
Copy link
Member Author

DavHau commented May 8, 2021

Oh, I just noticed it doesn't run any of the tests.

@DavHau DavHau marked this pull request as draft May 8, 2021 10:05
@fabaff
Copy link
Member

fabaff commented May 8, 2021

The fix for mwoauth is part of #121891 already.

@DavHau DavHau closed this May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ixxie ixxie Awaiting requested review from ixxie

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavHau @fabaff