-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackages.taffybar: fix build #122705
Conversation
@@ -1271,6 +1271,20 @@ self: super: { | |||
# Created upstream PR @ https://github.com/ghcjs/jsaddle/pull/119 | |||
jsaddle-webkit2gtk = appendPatch super.jsaddle-webkit2gtk ./patches/jsaddle-webkit2gtk.patch; | |||
|
|||
# 2021-05-12: gi-gdkpixbuf_2_0_26 fix | |||
# https://github.com/taffybar/gtk-sni-tray/pull/25 | |||
gtk-sni-tray = markUnbroken (appendPatch super.gtk-sni-tray (pkgs.fetchpatch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use markUnbroken
in nixpkgs itself, instead remove the packages in question from pkgs/development/haskell-modules/configuration-hackage2nix/broken.yaml
and run ./maintainers/scripts/haskell/regenerate-hackage-packages.sh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks, fixed.
|
Does it? I knew that taffybar was broken. I even opened an issue. But taffybar does not have a maintainer. So I didn‘t care very much. Before we put stuff in mergeable we should find maintainers for those packages. @rvl do you by any chance want to be a taffybar maintainer? Cons: You get pinged when it breaks. It’s nothing more than that. You are free to ignore the ping when it breaks. |
IMO that is too careless an approach. People use taffybar as part of their desktop setup and as far as I am aware it is not part of any test which controls the I'm more comfortable with breaking development tools and library dependencies, but I feel like we should invest extra time in keeping user-facing derivations working. The channel may be called |
Well, I didn‘t know that. That’s my point. I have no clue how many users taffybar has. I have heard about maybe 3. The point about maintained+mergeable jobs is that I don‘t have to make these judgement calls. If taffybar is that essential it should at least have a maintainer.
In general I totally agree. |
Yes Taffybar is a desktop component and it has a few users. |
Yes I remember that it was broken for good parts of the last year. But we can certainly try to increase the quality level here. |
Add patches to allow building with gi-gdkpixbuf_2_0_26 Upstream PRs: - taffybar/gtk-sni-tray#25 - taffybar/taffybar#507
@ofborg build taffybar |
passthru.env = taffybarEnv; | ||
|
||
# Will be faster to build the wrapper locally than to fetch it from a binary cache. | ||
preferLocalBuild = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell preferLocalBuild
will not prevent fetching from binary caches.
(There is a lot of uncertainty around this topic, I‘d be happy about a definitive answer.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allowSubstitutes
does that. preferLocalBuild
prevents remote builders from being used as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's cargo-culted from other wrappers.
It seems like something users would want, given that the packages parameter is configurable.
But I have no idea whether it's effective.
Perhaps it needs allowSubstitutes = false;
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave the flag. (It doesn‘t really matter that much either way.) I just believe the comment is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I fixed the comment and also added allowSubstitutes=false
because these two flags seem to be commonly used together for trivial derivations which often need to be built locally.
@ofborg build taffybar |
Add myself as a "maintainer" of taffybar, and also arbtt and lentil, for which I have made build fixes in the past.
Thank you for fixing this! And for maintaining stuff! |
@maralorn @rvl As the primary maintainer of taffybar (who is also a nix and nixos user) I'd prefer it if I was consulted before things like this were done in nixpkgs. I have merged @rvl 's change to gtk-sni-tray, and bumped its version, and made my own fix for taffybar itself, that should allow us to simply use newer versions that are actually on hackage instead of using patches. |
Feel free to add yourself as a maintainer by adding a corresponding entry to |
Oh, @IvanMalison that is great to know! And yeah, I really think that you should enter yourself as maintainer then. |
Hi @IvanMalison, I did link this PR with the gtk-sni-tray and taffybar PRs. We can simply remove those appendPatch overrides next time the Haskell packages set gets updated - whenever that might be. |
Motivation for this change
Add patches to allow building with gi-gdkpixbuf_2_0_26
Upstream PRs:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)