Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: Add GNOME #124005

Closed
wants to merge 1 commit into from
Closed

Conversation

piegamesde
Copy link
Member

Motivation for this change

I'd like to get notified whenever the GNOME extensions are changed. Then I noticed that ./pkgs/desktops/gnome has no owner at the moment. Adding @NixOS/gnome here seems sensible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented May 22, 2021

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners
The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 22, 2021
@piegamesde
Copy link
Member Author

Bummer. I don't plan to request commit access to nixpkgs only to get a few additional notifications.

I removed the line adding myself, adding only @NixOS/GNOME.

@zowoq
Copy link
Contributor

zowoq commented May 22, 2021

NixOS/GNOME doesn't have direct write permission to the repo so this will be a no op.

@piegamesde
Copy link
Member Author

That's even weirder. I haven't found a way to see whether a team has write access or not, but since other teams like php and podman are code owners as well, then it's probably best if GNOME gets write access too?

@zowoq
Copy link
Contributor

zowoq commented May 22, 2021

The other teams are actually no op as well. Only the security team has write access.

The teams don't have write access so we don't need to restrict team membership to only people with write access.

@piegamesde
Copy link
Member Author

Well, that's pointless then. I'll open an issue regarding the other teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants