-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go_1_17: init at 1.17.1 #127519
go_1_17: init at 1.17.1 #127519
Conversation
Except from https://tip.golang.org/doc/go1.17
This may change the hashes of vendorSha256 in existing packages that are using buildGoModule. |
Yeah, this release isn't going to be easy ...
Updating to 1.17 and pinning |
this feels like a pretty good reason to not force bump everything immediately - but instead give maintainers a chance to upgrade their modules as upstreams jump to 1.17 |
I'm keeping this in sync with the other |
I’d still like to see #127519 (comment) at least partially resolved before this lands or soon after - it’s becoming difficult to track their history. this explicitly is not a nitpick, but something important to longer term maintainability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any chance we can get this landed? It's been 2 weeks since go1.17 was released publicly and it would be great to use this without having to maintain a fork :). |
re: updating the hashes - I still have my code (and it's somewhere on either github or git.sr.ht), which will autoregen all the hashes for go packages, so I can probably get most packages that are compatible bulk migrated once this lands. |
We can merge this go make @NixOS/golang Are we okay with that and the comment I've added in |
@zowoq Is this a ticket to track work needed to begin considering allow |
@@ -19158,6 +19174,15 @@ in | |||
buildGo116Module = callPackage ../development/go-modules/generic { | |||
go = buildPackages.go_1_16; | |||
}; | |||
# go_1_17 has go module changes which may not be portable | |||
# across different go versions and/or platforms, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate what implications this has on things we're trying to build with buildGo117Module
?
# go_1_17 has go module changes which may not be portable | ||
# across different go versions and/or platforms, | ||
# it also requires >=10.13 stdenv on darwin which | ||
# is not currently available for x86_64-darwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just mark each derivation built with buildGo117Package
on x86_64-darwin
as broken?
hey, could you send the script if you still have it? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/missing-go-1-17-on-x86-64-darwin/15032/3 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)