Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmpi: re-enable fortran on aarch64-darwin #128606

Merged
merged 1 commit into from
Jun 29, 2021
Merged

openmpi: re-enable fortran on aarch64-darwin #128606

merged 1 commit into from
Jun 29, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jun 29, 2021 •
edited
Loading

Motivation for this change
  • re-enable fortran on aarch64-darwin by disabling stackprotector hardening
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@prusnak
openmpi: re-enable fortran on aarch64-darwin
cca0869 
by disabling stackprotector hardening
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 29, 2021
@prusnak prusnak mentioned this pull request Jun 29, 2021
Closed
@prusnak prusnak requested review from vcunat and purcell June 29, 2021 09:37
@prusnak prusnak mentioned this pull request Jun 29, 2021
Merged
11 tasks
@ofborg ofborg bot requested a review from markuskowa June 29, 2021 09:47
vcunat
vcunat approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, looks like giving more consistency among platforms.

No idea why stackprotector triggers this. I'd hope that it's about the platform being new and that upstreams will resolve such corner cases over time.

@prusnak prusnak merged commit a6a026a into NixOS:master Jun 29, 2021
@prusnak prusnak deleted the openmpi branch June 29, 2021 10:05
@purcell
Copy link
Member

purcell commented Jun 30, 2021

Yay, great!

prusnak added a commit to prusnak/nixpkgs that referenced this pull request Jul 28, 2021
@prusnak
python3Packages.scipy: fix build on aarch64-darwin
dd615c6 
by disabling stack-protector

essentially the same fix as we used for openmpi in
NixOS#128606
@prusnak prusnak mentioned this pull request Jul 28, 2021
Merged
11 tasks
FRidh pushed a commit that referenced this pull request Jul 29, 2021
@prusnak @FRidh
python3Packages.scipy: fix build on aarch64-darwin
f97fb96 
by disabling stack-protector

essentially the same fix as we used for openmpi in
#128606
@collares collares mentioned this pull request Feb 10, 2022
Merged
13 tasks
@ConnorBaker ConnorBaker mentioned this pull request Mar 28, 2022
Merged
13 tasks
@collares collares mentioned this pull request Apr 13, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@markuskowa markuskowa markuskowa approved these changes

@purcell purcell Awaiting requested review from purcell

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prusnak @purcell @vcunat @markuskowa