duckmarines: init at 1.0b #13504
Merged
duckmarines: init at 1.0b #13504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sha256 = "0fpzbsgrhbwm1lff9gyzh6c9jigw328ngddvrj5w7qmjcm2lv6lv"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ lua love ]; |
There was a problem hiding this comment.
Both lua and love are actually needed to run the game and not to build it therefore both are normal buildInputs and belong there. makeWrapper on the other side can be placed in nativeBuildInputs. unzip is native as well but see below.
This was referenced Feb 27, 2016
Merged
leenaars
added a commit
to leenaars/nixpkgs
that referenced
this pull request
Feb 27, 2016
As suggested in NixOS#13504 by @hrdinka.
leenaars
force-pushed
the
duckmarines
branch
2 times, most recently
from
c2dc1f7
to
2bcc04a
Compare
vcunat
pushed a commit
that referenced
this pull request
Feb 27, 2016
| nativeBuildInputs = [ makeWrapper ]; | ||
| buildInputs = [ lua love ]; | ||
|
|
||
| phases = "unpackPhase installPhase"; |
There was a problem hiding this comment.
phases expects a single string if there is only a single phase. If there are more than one you have to define a list of strings. Therefore phases = [ "unpackPhase" "installPhase" ] would be correct.
leenaars
force-pushed
the
duckmarines
branch
from
2bcc04a
to
ad23ac7
Compare
|
Built & tested locally. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A game created with LÖVE.