Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boringssl: add the "dev" output to match openssl #143477

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Oct 28, 2021

Motivation for this change

This allows building curl with a openssl = boringssl override. Tested by building curl with the boringssl override and nginxQuic.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This allows building curl with a `openssl = boringssl` override.
@SuperSandro2000
Copy link
Member

If all packages would use lib.getDev instead of openssl.dev this would just work ™️ .

@bobrik
Copy link
Contributor Author

bobrik commented Nov 19, 2021

Sounds reasonable: #146646.

@bobrik bobrik closed this Nov 19, 2021
@roberth
Copy link
Member

roberth commented Nov 22, 2021

From the looks of it, this was a good change, reducing runtime closure size a little.

bobrik added a commit to bobrik/nixpkgs that referenced this pull request Nov 24, 2021
@bobrik
Copy link
Contributor Author

bobrik commented Nov 25, 2021

I can reopen if you want to merge it.

@roberth roberth reopened this Nov 26, 2021
@roberth roberth merged commit 68331b5 into NixOS:master Nov 26, 2021
@roberth
Copy link
Member

roberth commented Nov 26, 2021

Thanks!

@bobrik bobrik deleted the ivan/boringssl-dev branch December 4, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants