Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epson-escpr2: 1.1.38 -> 1.1.42 #143639

Merged
merged 1 commit into from
Oct 29, 2021
Merged

epson-escpr2: 1.1.38 -> 1.1.42 #143639

merged 1 commit into from
Oct 29, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 29, 2021

Motivation for this change

New upstream releases.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions
Copy link
Contributor

Backport failed for release-21.05, due to an unknown script error.

Please cherry-pick the changes locally.

git fetch origin release-21.05
git worktree add -d .worktree/backport-143639-to-release-21.05 origin/release-21.05
cd .worktree/backport-143639-to-release-21.05
git checkout -b backport-143639-to-release-21.05
ancref=$(git merge-base 85850ea4fccb0223d34695a428f0104de1cf7110 b9170bf9e0e4d4791ab7fcfb610cc88a90869590)
git cherry-pick -x $ancref..b9170bf9e0e4d4791ab7fcfb610cc88a90869590

@Ma27
Copy link
Member Author

Ma27 commented Oct 29, 2021

@domenkozar is it possible that something went wrong with 7e3ba3e? The patch applies cleanly for me on 21.05 oO

@domenkozar
Copy link
Member

I was attempting to fix this but even bumping to 0.0.7 doesn't help. I suggest we revert to 0.0.5

@domenkozar
Copy link
Member

Fixed

@korthout
Copy link

korthout commented Jul 7, 2022

I was attempting to fix this but even bumping to 0.0.7 doesn't help. I suggest we revert to 0.0.5

@domenkozar This is an old issue, but I think I've pinpointed the error. If you have the time, please update to v0.0.8 by changing the checkout-action step configuration to use only the defaults (i.e. - uses: actions/checkout@v2 no with needed). Please let me know if I can assist you with this in any way.

This update should also massively speed up the checkouts in your workflow, as it's currently configured to fetch all history for all branches and tags with fetch-depth: 0, while by default it only fetches 1 commit. Note that the newer v0.0.8 is more resilient than v0.0.7, and further improvements should be coming now that I've finally got testing under control.

Details on the error: v0.0.6 of the backport-action and higher expect to be run after a checkout of the pull request base branch (this is the default for the checkout action). However, at the time the checkout action in your backport workflow was configured to checkout the pull request head branch. I was able to reproduce this here with just this change on v0.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants