-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/gdm: enable nvidiaWayland by default #147153
nixos/gdm: enable nvidiaWayland by default #147153
Conversation
Should this be backported to 21.11 🤔 ? |
I don't think so, there might be some more polishing up to do so I would prefer this change to be only on unstable for the time being. I have noticed some issues with electron for example but havent been able to diagnose that. |
559ebbf
to
539811a
Compare
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe someone with more knowledge with Gnome can help here?
I think it is a good idea if Wayland is generally usable on nvidia. I cannot verify whether this is the case. |
For reference, that flag was added ~2 years ago in #70295 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/request-for-testers-nvidia-gpu-and-gdm-gnome-users/16265/1 |
I was using this flag for success for quite some time but fortunately I was able to move to AMD graphics. So I'll step out of this review since a lot of people better suited to answer this question have been brought in. |
Hi @teto and @rofrol, noticed you thumbs upped this merge request; if you have tested this config I would appreciate an approval through the merge review flow. @jtojnar, I am using a config with wayland under nvidia and gdm + gnome 41 so I know this works great overall. I made good faith efforts to get gdm + nvidia testers and it seems like there are no objections. I think this is ready to merge. |
Not getting any response from the gnome folk. I think we can merge this. It worked fine for me and matches other driver settings. |
This appears to be set even if
|
Thanks, should be fixed by dad4fdd. |
Looks like docs are outdated now. |
Motivation for this change
With the recent improvements on different libraries and drivers the wayland experience is way better than a year ago. WebGL, Steam, and many graphics things work great nowadays and this change would reflect that new level of polish. (GDK has also improved a lot, it used to be that changing the keyboard layout would not change the hotkey layout which was a bit confusing between qwerty and dvorak)
While this would allow wayland on nvidia by default, GDM includes a toggle between wayland and x11 and wayland/nvidiaWayland module options would still be configurable by end users.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes