Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woeusb-ng: init at 0.2.10 #149382

Merged
merged 1 commit into from
Dec 26, 2021
Merged

woeusb-ng: init at 0.2.10 #149382

merged 1 commit into from
Dec 26, 2021

Conversation

Stunkymonkey
Copy link
Contributor

Motivation for this change

woeusb is beeing rewritten in python: https://github.com/WoeUSB/WoeUSB-ng

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Stunkymonkey
Copy link
Contributor Author

maybe @bjornfor maintaining woeusb can comment on this?

@bjornfor
Copy link
Contributor

bjornfor commented Dec 9, 2021

I think it'd be nice to ask upstream what we should package. Both? Or one of them? What do they recommend for users? (I personally have no opinion.)

@Stunkymonkey
Copy link
Contributor Author

@bjornfor the maintainer suggested in splitting up. So from my point of view the PR is complete.

@bjornfor
Copy link
Contributor

The way I read it (question and answer) was about splitting gui and cli, not about woeusb vs the new rewrite: woeusb-ng. So I'm as confused as before which package upstream recommends to users.

@Stunkymonkey
Copy link
Contributor Author

Sorry, I misunderstood your question.

@Stunkymonkey
Copy link
Contributor Author

since the parameters are different i suggest to add it as a new package.

@Stunkymonkey
Copy link
Contributor Author

should all be fixed.

@bjornfor bjornfor merged commit fedde5d into NixOS:master Dec 26, 2021
@Stunkymonkey Stunkymonkey deleted the woeusb-ng branch February 14, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants