Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclutter: switch to user service and add options #15228

Merged
merged 1 commit into from
May 5, 2016

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented May 4, 2016

Things done
  • Tested in a NixOS vm
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Unclutter has the same problem of redshift (issue #14882) so this will run it as a user service.
I haven't tested every option (excluded in particular) but the arguments seem ok.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @anderspapitto and @edolstra to be potential reviewers

services.unclutter.arguments = mkOption {
description = "Arguments to pass to unclutter command";
default = "-idle 1";
package = mkOption {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious: as a user, why would I want to change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought one may want to use a fork or a custom version. There is also a rewrite of the original package called unclutter-xfixes. I'm not sure the arguments are compatible though.

@joachifm
Copy link
Contributor

joachifm commented May 5, 2016

Thank you

@joachifm joachifm merged commit 5f09248 into NixOS:master May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants