Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gvfs: fix libmtp udev package path #152289

Merged
merged 1 commit into from
Dec 27, 2021
Merged

nixos/gvfs: fix libmtp udev package path #152289

merged 1 commit into from
Dec 27, 2021

Conversation

lovesegfault
Copy link
Member

As pointed out by @sigprof1 my bump of libmtp silently broke this, as I
moved the udev files out of the bin output of the pkg.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@lovesegfault
nixos/gvfs: fix libmtp udev package path
2d7fc66 
As pointed out by @sigprof[1] my bump of libmtp silently broke this, as I
moved the udev files out of the bin output of the pkg.

[1]: NixOS#144290 (comment)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 26, 2021
@lovesegfault lovesegfault mentioned this pull request Dec 26, 2021
Merged
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 26, 2021
@lovesegfault lovesegfault merged commit f6d17af into NixOS:master Dec 27, 2021
@lovesegfault lovesegfault deleted the fix-mtp-udev-path branch December 27, 2021 02:28
@github-actions github-actions bot mentioned this pull request Dec 27, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #152306 for release-21.11.

@jtojnar jtojnar mentioned this pull request Dec 27, 2021
Closed
@MatthewCroughan
Copy link
Contributor

MatthewCroughan commented Dec 27, 2021 •
edited
Loading

I've rebased my MTP test on master where this fix is merged. And voila, the test now passes. This seems to have fixed the issue. #146084

@andrevmatos andrevmatos mentioned this pull request Dec 28, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovesegfault @MatthewCroughan