Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.roboschool: remove #154998

Merged
merged 1 commit into from
Jan 14, 2022
Merged

python.pkgs.roboschool: remove #154998

merged 1 commit into from
Jan 14, 2022

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 14, 2022

Motivation for this change

Currently broken [1]. Has been deprecated for a while [2].

[1] #151469
[2] https://github.com/openai/roboschool/blob/d32bcb2b35b94168b5ce27233ca62f3c8678886f/README.md

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 14, 2022
@timokau timokau merged commit 86be30d into NixOS:master Jan 14, 2022
@timokau timokau deleted the remove-roboschool branch January 14, 2022 13:48
@timokau timokau mentioned this pull request Jan 14, 2022
Closed
54 tasks
@jonringer
Copy link
Contributor

There should be an entry in python-aliases.nix which states that it was removed

@timokau timokau mentioned this pull request Jan 15, 2022
Merged
13 tasks
@timokau
Copy link
Member Author

timokau commented Jan 15, 2022

I wasn't aware of that convention, thank you for letting me know. Continued in #155095.

mmahut pushed a commit that referenced this pull request Jan 15, 2022
@timokau
python.pkgs.roboschool: mark as removed
9042e83 
I recently removed roboschool, but did not add an alias with a removal
notice. As suggested by [1].

[1] #154998 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timokau @jonringer