AWS C/C++ library bumps #160281
Merged
AWS C/C++ library bumps #160281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2022
|
I can't finish a nixpkgs-review because of #160289 but this seems to be working well. The only failures I noticed are already broken python packages. |
|
Result of 4 packages marked as broken and skipped:
3 packages blacklisted:
5 packages failed to build:
121 packages built:
only preexisting failures |
|
Nice, thanks for the proper review. This has been up for a while and seems to be good to go so I'll plan to merge in 24 hours if no further reviews |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-21.11
git worktree add -d .worktree/backport-160281-to-release-21.11 origin/release-21.11
cd .worktree/backport-160281-to-release-21.11
git checkout -b backport-160281-to-release-21.11
ancref=$(git merge-base 6d5e3764dd3802fe55d8753e27daeb14a76ce0e0 e3aaf2da828f418bae0c70571209580e7f017b9d)
git cherry-pick -x $ancref..e3aaf2da828f418bae0c70571209580e7f017b9d |
|
I see aws-c-common breaking on x86_64-darwin: https://hydra.nixos.org/job/nixpkgs/trunk/aws-c-common.x86_64-darwin That's a blocker for the |
|
Looks like it worked 20 days ago https://github.com/NixOS/nixpkgs/runs/5224243299 |
|
The message is suspicious. The file exists (in cache.nixos.org): EDIT: well, let's restart the build at least once 🤷🏽 |
|
It succeeded on Hydra, after some more issues with the farm. So I'll assume that this PR wasn't at fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping aws-c-* collection, s2n-tls, and aws-crt-cpp to the latest versions.
Motivation for this change
These packages are all highly interdependent, and breaking changes in one can require updates in lockstep, so it makes sense to bundle these bumps into a single PR.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes