factor-lang: Init at 0.97 #16059
factor-lang: Init at 0.97 #16059
Conversation
| @@ -6914,6 +6914,11 @@ in | |||
|
|
|||
| faad2 = callPackage ../development/libraries/faad2 { }; | |||
|
|
|||
| factor-lang = callPackage ../development/compilers/factor-lang { | |||
| inherit (pkgs.gnome) gtkglext; | |||
| glib = glib; | |||
There was a problem hiding this comment.
this line is unnecessary.
There was a problem hiding this comment.
@the-kenny Removed the redundant assignment.
vrthra
changed the title
vrthra
changed the title
|
@rushmorem Ready for review. |
| mv factor/factor.image bin/.factor-wrapped.image && | ||
| rm -rf factor ) | ||
|
|
||
| cp -r basis core extra unmaintained $out/bin |
There was a problem hiding this comment.
Are all these required at run-time? If they are, can't they be moved outside the bin directory?
There was a problem hiding this comment.
Unfortunately, factor looks for the libraries and runtime image in the directory where the binary was found.
There was a problem hiding this comment.
Updated to use the lib/factor directory instead.
|
This failed to build for me locally. I'm getting the following error:- |
|
@rushmorem "refusing to evaluate." Is this message coming from the Nix? Any idea? I don't see that message in factor libraries. |
| cp -r basis core extra unmaintained $out/bin | ||
|
|
||
| # Factor uses the home directory for cache during compilation. | ||
| # We cant have that. So set it to $out/.home |
There was a problem hiding this comment.
The comment is still mentioning $out...
|
@vrthra yes that message comes from Nix. |
|
Your branch is now outdated. Please kindly rebase against master. |
| description = "A concatenative, stack-based programming language"; | ||
|
|
||
| maintainers = [ maintainers.vrthra ]; | ||
| platforms = [ platforms.linux ]; |
There was a problem hiding this comment.
This is where nix-build is choking (see comment) which is odd because I'm running NixOS. Unless I'm missing something it should continue to build for me. The relevant if condition looks suspicious to me (I have not configured to allow broken builds and here platforms is set). If I remove this line the build does continue. @the-kenny any thoughts on this? /cc @edolstra
There was a problem hiding this comment.
Never mind my previous comment. platforms = [ platforms.linux ]; should be platforms = platforms.linux; instead. @vrthra once you make this change and rebase against master we should finally be ready to merge.
|
@rushmorem Rebased and pushed. |
|
@vrthra thanks. We are almost there... Once you correct the |
Factor is a concatenative, stack-based programming language.
|
@rushmorem updated the platforms |
|
Thank you. It's building now. I will merge it if it finishes successfully. |
rushmorem
added
8.has: package (new)
|
Local build finished successfully. Thanks! |
|
@rushmorem this seems to have failed the nightly build with Any idea what I should do now? |
|
@rushmorem Disabling i686 builds at PR:#16089 |
|
OK, thanks. I will take a look at it. |
Motivation for this change
New package Factor
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Factor is a concatenative, stack-based programming language.