tmux-thumbs: init at 0.7.1

[ghostbuster91]

Motivation for this change

Add https://github.com/fcsonline/tmux-thumbs

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[legendofmiracles]

Both diffs also apply to your other derivation

Thanks!

[hqurve]

You forgot to apply the changes suggested by legendofmiracles to this file too.

After this, its good. Thanks

PS: I havent actually tested it as I dont have the means, but it looks good and builds. So, im assuming that it works for you

[ghostbuster91]

You forgot to apply the changes suggested by legendofmiracles to this file too.

After this, its good. Thanks

PS: I havent actually tested it as I dont have the means, but it looks good and builds. So, im assuming that it works for you

Oh I see, sorry got lost a little bit. I will fix the in a minute. Many thanks for the review!

[ghostbuster91]

PS: I havent actually tested it as I dont have the means, but it looks good and builds. So, im assuming that it works for you

Yes, I use it all the time, and my setup is based on this particular changes.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/447

[SuperSandro2000]

Please combine this like

nixpkgs/pkgs/applications/audio/curseradio/default.nix

Lines 20 to 25 in 51ceca2

	patches = [
	(substituteAll {
	src = ./mpv.patch;
	inherit mpv;
	})
	];

[ghostbuster91]

I am not sure if it is possible, at last I haven't found a way to do this. The substitution uses out but I cannot use it as a nix variable because the derivation hasn't been created yet.

Following code correctly complains about out being undefined:

 patches = [
    (substituteAll {
      src = ./fix.patch;
      thumbsBinDir = "${out}/bin";
    })
  ];

Am I missing something?

[SuperSandro2000]

I think one of the following should work:

 patches = [
    (substituteAll {
      src = ./fix.patch;
      thumbsBinDir = "$out/bin";
    })
  ];

or

 patches = [
    (substituteAll {
      src = ./fix.patch;
      thumbsBinDir = "${placeholder "out"}/bin";
    })
  ];

[ghostbuster91]

Unfortunately, neither of them works. My debugging capabilities of that are very limited but I was about to observe following errors:
With first solution:

 patches = [
    (substituteAll {
      src = ./fix.patch;
      thumbsBinDir = "$out/bin";
    })
  ];

Not a directory : $out/bin/thumbs

With second solution:

 patches = [
    (substituteAll {
      src = ./fix.patch;
      thumbsBinDir = "${placeholder "out"}/bin";
    })
  ];

Not a directory: /nix/store/some-hash-fix.patch/bin/thumbs

Could it be possible that in the second case we somehow refer to the output of the substituteAll function?

[ghostbuster91]

@SuperSandro2000 I managed to get rid completely of this one substitute :)

[auroraanna]

Come on ;_; why didn't you mention this PR in #161792? I've made a duplicate PR now. Closing it.

[ghostbuster91]

@papojari Sorry, my bad. I've just simply forgot to do that. Thanks.