-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kitty: 0.24.2 -> 0.24.4 #162215
kitty: 0.24.2 -> 0.24.4 #162215
Conversation
A test fails on macOS. I'll need to investigate. |
fd213ff
to
b2c0ceb
Compare
FYI: Looks like 0.24.4 has been released already. |
This should be updated to
|
ead6b0f
to
c375c6e
Compare
I'm not a nix pro and not really familiar with the nixpkgs guidelines but this PR looks fine to my eyes. I'm also able to compile kitty and it runs. Thanks! |
Yep, seems to work now. I'll wait for one more response from upstream and modify the commit message to credit @page-down, then I'll mark this as ready to review. |
Also change the command invocation to be consistent with the official documentation. These changes were suggested by @page-down in NixOS#162215 (comment). Thank you!
@leungbk 21.05? You probably mean 22.05, right? |
@Luflosi Whoa sorry, I was browsing this PR yesterday without intending to modify it and must have unwittingly done something. I cannot seem to remove the Milestone tag for some reason, possibly bc I am on phone. |
No problem, I removed it from the milestone. |
Motivation for this change
https://github.com/kovidgoyal/kitty/releases/tag/v0.24.4
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes