kitty: 0.24.2 -> 0.24.4

[Luflosi]

Motivation for this change

https://github.com/kovidgoyal/kitty/releases/tag/v0.24.4

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[Luflosi]

A test fails on macOS. I'll need to investigate.

[jtrees]

FYI: Looks like 0.24.4 has been released already.

[page-down]

@Luflosi

This should be updated to fish2 (the second version of fish completion).
In terms of style, the +complete namespace is recommended. (Without the space in between. (Just a suggestion, consistent with all styles in the official documentation.)

installShellCompletion --cmd kitty \
...
--fish <("$out/bin/kitty" + complete setup fish) \

[jtrees]

I'm not a nix pro and not really familiar with the nixpkgs guidelines but this PR looks fine to my eyes. I'm also able to compile kitty and it runs. Thanks!

[Luflosi]

Yep, seems to work now. I'll wait for one more response from upstream and modify the commit message to credit @page-down, then I'll mark this as ready to review.
Thanks @page-down for your suggestion.

[Luflosi]

@leungbk 21.05? You probably mean 22.05, right?

[leungbk]

@Luflosi Whoa sorry, I was browsing this PR yesterday without intending to modify it and must have unwittingly done something. I cannot seem to remove the Milestone tag for some reason, possibly bc I am on phone.

[Luflosi]

No problem, I removed it from the milestone.