treesheets: adjust output directories #163492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs are now under $out/share/doc/treesheets instead of top level in the doc/ directory. The libexec/ directory is now directly under $out to match Nixpkgs conventions.
|
I am tackling this upstream in aardappel/treesheets#201 |
|
Okay, I'll keep this open in the interim until the upstream PR is merged. |
13 tasks
|
Closing this in favor of #163872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Right now, the treesheets derivation outputs docs to
$out/share/doc/This is undesirable, because if you install Treesheets into, say, your profile, you end up with its readme under~/.nix-profile/share/doc/readme.html. This patch moves Treesheets docs to$out/share/doc/treesheets/instead.Also, I've moved
$out/share/libexecto$out/libexec; this seems to be the common Nixpkgs convention.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes