Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chickenPackages_5: more eggs #165023

Merged
merged 27 commits into from
May 4, 2022
Merged

chickenPackages_5: more eggs #165023

merged 27 commits into from
May 4, 2022

Conversation

nagy
Copy link
Member

@nagy nagy commented Mar 20, 2022

Description of changes

More Chicken eggs 🥚🥚🥚

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mindavi
Copy link
Contributor

Mindavi commented May 3, 2022

Needs a rebase

@nagy
Copy link
Member Author

nagy commented May 3, 2022

has been rebased

@Mindavi
Copy link
Contributor

Mindavi commented May 3, 2022

Built:

  • legacyPackages.x86_64-linux.chickenPackages_5.pkgs.chickenEggs.sha2
  • legacyPackages.x86_64-linux.chickenPackages_5.pkgs.chickenEggs.spiffy

Do you know the reason why this set is not recursed into?

Planning the merge when ofborg is happy.

@nagy
Copy link
Member Author

nagy commented May 3, 2022

Do you know the reason why this set is not recursed into?

I do not, but I think it should be.

@Mindavi Mindavi merged commit 113375e into NixOS:master May 4, 2022
@nagy nagy deleted the chicken5-eggs branch May 4, 2022 07:58
@nagy
Copy link
Member Author

nagy commented May 4, 2022

I have implemented this here nagy@ad055de and it works fine.

I will make a PR out of it.

nagy added a commit to nagy/nixpkgs that referenced this pull request May 4, 2022
This makes chicken packages (eggs) discoverable.

This came up during:

NixOS#165023 (comment)
@nagy nagy mentioned this pull request May 4, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants