Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godns: 2.7.1 -> 2.7.3 #167041

Merged
merged 1 commit into from
Apr 9, 2022
Merged

godns: 2.7.1 -> 2.7.3 #167041

merged 1 commit into from
Apr 9, 2022

Conversation

linyinfeng
Copy link
Member

@linyinfeng linyinfeng commented Apr 3, 2022

Description of changes

Update to 2.7.2 2.7.3.

Upstream release notes:

Version v2.7.3 only includes a tiny fix TimothyYe/godns#144.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging this I can provide a module to configure the service which also supports secrets from tools like agenix. I have contributed a change to read secrets from files.

@tboerger
Copy link
Member

tboerger commented Apr 3, 2022

@linyinfeng maybe you want to take a look at #167060 which already integrates the new config values?

@linyinfeng linyinfeng changed the title godns: 2.7.1 -> 2.7.2 godns: 2.7.1 -> 2.7.3 Apr 4, 2022
@linyinfeng linyinfeng requested a review from tboerger April 4, 2022 03:11
@linyinfeng
Copy link
Member Author

@linyinfeng maybe you want to take a look at #167060 which already integrates the new config values?

Sure! Thank you for the module! I have left some comments in #167060.

@bobby285271 bobby285271 merged commit d60942f into NixOS:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants