starfetch: init at 0.0.2 #167541
starfetch: init at 0.0.2 #167541
Conversation
|
Whoops, my automatic |
|
It's fixed now. |
|
Result of 1 package built:
|
|
Added |
ofborg
bot
added
11.by: package-maintainer
|
Updated to newest commit. |
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "starfetch"; | ||
| version = "unstable-2022-04-06"; |
There was a problem hiding this comment.
Since the maintainer is interested in this being packaged id advise they tag a version 0.0.1
People are more likely to package a release than a commit
auroraanna
added
the
2.status: blocked by pr/issue
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
|
currently blocked by |
auroraanna
removed
the
2.status: blocked by pr/issue
|
Everything should be fixed now. I patched the source code to have the nix store paths. |
| }; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace ./src/starfetch.cpp --replace /usr/local/starfetch $out |
There was a problem hiding this comment.
You should use makeFlags instead of patching
There was a problem hiding this comment.
What does makeFlags have to do with the paths inside the source code? If starship.cpp is hardcoded to /usr/local how is makeFlags gonna change that?
There was a problem hiding this comment.
Ah its the cpp files.
If its the res dir it shouldn't be at the root of the $out
There was a problem hiding this comment.
I asked the developer about that too: Haruno19/starfetch#2
There was a problem hiding this comment.
Should we tell him to put it somewhere in /usr/share?
There was a problem hiding this comment.
🤷 not sure. I haven't even looked deep enough to work out if these resources are static or should be updated etc so I couldn't give an accurate answer
There was a problem hiding this comment.
Should we tell him to put it somewhere in
/usr/share?
So, would it be better to use /usr/share/starfetch rather than /usr/local/starfetch to store resource files (txt and json files)?
There's no problem in changing that, but may I ask why?
There was a problem hiding this comment.
I'd imagine the argument is:
/usr/share : Architecture-independent data
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s11.html
Within /usr/local you could do /usr/local/share/starfetch but probably not /usr/local/starfetch
No other directories, except those listed below, may be in /usr/local after first installing a FHS-compliant system.
see the directories section here
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s09.html
So TL;DR /usr/share/starfetch or /usr/local/share/starfetch would be your options
And then I personally wouldn't add a res subdir since your res dir already is split nicely into 2 files and a dir
constellations/
help_message.txt
template
There was a problem hiding this comment.
Thank you for the exhaustive reply.
I'll implement this changes as soon as possible, and then add a new release.
There was a problem hiding this comment.
Release 0.0.2 is now out. Files are now stored into /usr/local/share/starfetch/ and the res/ subdir has been removed.
auroraanna
changed the title
|
I don't know if it's possible to use the makefile's install section for installing but I figured it doesn't make sense anyway because there are some commands in the makefile that aren't needed with Nix. |
Description of changes
Add the starfetch package
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes