-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hydra-unstable: 2022-02-07 -> 2022-05-03 #173218
Conversation
The fixed link failure should be a result of nix commit da7d8da |
Diff LGTM now, I'll maybe install this later today and test it out further. Thanks for picking this up! |
@ofborg build hydra_unstable |
I had some issues upgrading due to sddm breakages :(, so didn't get a good chance to test this (though it seemed it did at least start running). |
It's running riscv builds fine on my machine (even with nixUnstable and a bit more patching). |
The ofborg failure looks like just a timeout? |
Seems like an unstable test, which is annoying since it prevents hydra being cached properly. Are you willing to look into this (e.g. disable the test for now)? Would be nice if ofborg and hydra are happy with this too. |
I got this to build locally and it looks good. The diff viewer (scmdiff) is broken, but that due to this issue and should be handled upstream: #169193. |
Noting the test fail here for reference: Failure executing slapadd -F /build/yath-4590-S6UpHp/tmp/EMc9Hr/UWkQCivT0y/slap.d -b dc=example -l /build/yath-4590-S6UpHp/tmp/EMc9Hr/UWkQCivT0y/load.ldif. Also seeing some 'unexpected EOF', but that's probably nix bugs :(. |
I tried rebuilding multiple times, no luck to reproduce the failure, does ofborg configure nix daemon in a particular way that makes this happen? |
Not sure. I managed to reproduce it though, although rarely. |
Might need to disable that Hydra/Controller/User/ldap-legacy.t test to reduce the amount of failures we'll see on hydra. Result of 3 packages built:
Been running this for a few days now and looks good otherwise. |
Would a simple rm do the trick? |
Yeah, that'd probably work fine. |
@Mindavi Why was the pin moved from v2.8 to v2.6? I would even argue to remove the pin, if I run e.g. a 22.05 hydra, I would assume it uses the same nix for evaluation as a regular NixOS 22.05 |
It's now back on 2.8 actually. |
Because nix doesn't have a stable enough API yet, so building against latest nix occasionally fails. I prefer hydra not failing to build whever nix is bumped. It's indeed on 2.8 now. Feel free to locally override, with the sidenote that it'll inevitably fail to build one day. |
I think hydra is important enough to be updated in parallel to nix, so not pinning it would make sure of that.
Right, I just realized the fix just has not hit unstable yet.
We should not force people to build their own hydra just to have consistent nix behavior out of the box. So alternatively, to make the current scheme work, maybe we could passthru |
No, Hydra's development is generally based on an old version of Nix because Nix's development disregards Hydra. Hydra upstream pinned Nix 2.4 until recently. And the Hydra packaging in Nixpkgs is even less important than Hydra itself (hydra.nixos.org runs on Hydra master via flakes). :( |
Hmm, ok. It would at least be nice to make that pin easily available then, so I proposed to add it to the passthru in #175452. |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes