Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra-unstable: 2022-02-07 -> 2022-05-03 #173218

Merged
merged 2 commits into from
May 21, 2022
Merged

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented May 16, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@NickCao NickCao marked this pull request as ready for review May 16, 2022 01:53
@NickCao
Copy link
Member Author

NickCao commented May 16, 2022

The fixed link failure should be a result of nix commit da7d8da

@ofborg ofborg bot requested review from lheckemann, dasJ and Mindavi May 16, 2022 02:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 16, 2022
@Mindavi
Copy link
Contributor

Mindavi commented May 16, 2022

Diff LGTM now, I'll maybe install this later today and test it out further. Thanks for picking this up!

@ofborg ofborg bot requested a review from Mindavi May 16, 2022 06:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1 labels May 16, 2022
@ofborg ofborg bot requested a review from lheckemann May 16, 2022 08:29
@Mindavi Mindavi mentioned this pull request May 18, 2022
9 tasks
@Mindavi
Copy link
Contributor

Mindavi commented May 18, 2022

@ofborg build hydra_unstable

@Mindavi
Copy link
Contributor

Mindavi commented May 18, 2022

I had some issues upgrading due to sddm breakages :(, so didn't get a good chance to test this (though it seemed it did at least start running).

@NickCao
Copy link
Member Author

NickCao commented May 18, 2022

It's running riscv builds fine on my machine (even with nixUnstable and a bit more patching).

@NickCao
Copy link
Member Author

NickCao commented May 18, 2022

The ofborg failure looks like just a timeout?
A timeout (event) has occured (after 60.9713 seconds), job was forcefully killed

@Mindavi
Copy link
Contributor

Mindavi commented May 18, 2022

Seems like an unstable test, which is annoying since it prevents hydra being cached properly.

Are you willing to look into this (e.g. disable the test for now)? Would be nice if ofborg and hydra are happy with this too.

@Mindavi
Copy link
Contributor

Mindavi commented May 19, 2022

I got this to build locally and it looks good. The diff viewer (scmdiff) is broken, but that due to this issue and should be handled upstream: #169193.

@Mindavi
Copy link
Contributor

Mindavi commented May 20, 2022

Noting the test fail here for reference:

Failure executing slapadd -F /build/yath-4590-S6UpHp/tmp/EMc9Hr/UWkQCivT0y/slap.d -b dc=example -l /build/yath-4590-S6UpHp/tmp/EMc9Hr/UWkQCivT0y/load.ldif.

Also seeing some 'unexpected EOF', but that's probably nix bugs :(.

@NickCao
Copy link
Member Author

NickCao commented May 20, 2022

I tried rebuilding multiple times, no luck to reproduce the failure, does ofborg configure nix daemon in a particular way that makes this happen?

@Mindavi
Copy link
Contributor

Mindavi commented May 20, 2022

Not sure. I managed to reproduce it though, although rarely.

@Mindavi
Copy link
Contributor

Mindavi commented May 21, 2022

Might need to disable that Hydra/Controller/User/ldap-legacy.t test to reduce the amount of failures we'll see on hydra.

Result of nixpkgs-review pr 173218 run on x86_64-linux 1

3 packages built:
  • hydra_unstable
  • perl532Packages.TestPostgreSQL
  • perl534Packages.TestPostgreSQL

Been running this for a few days now and looks good otherwise.

@Mindavi Mindavi merged commit c0fd7af into NixOS:master May 21, 2022
@NickCao
Copy link
Member Author

NickCao commented May 21, 2022

Might need to disable that Hydra/Controller/User/ldap-legacy.t test to reduce the amount of failures we'll see on hydra.

Would a simple rm do the trick?

@Mindavi
Copy link
Contributor

Mindavi commented May 21, 2022

Yeah, that'd probably work fine.

@NickCao NickCao deleted the hydra-update branch May 21, 2022 15:15
@FlorianFranzen
Copy link
Contributor

@Mindavi Why was the pin moved from v2.8 to v2.6? I would even argue to remove the pin, if I run e.g. a 22.05 hydra, I would assume it uses the same nix for evaluation as a regular NixOS 22.05

@NickCao
Copy link
Member Author

NickCao commented May 23, 2022

@Mindavi Why was the pin moved from v2.8 to v2.6? I would even argue to remove the pin, if I run e.g. a 22.05 hydra, I would assume it uses the same nix for evaluation as a regular NixOS 22.05

It's now back on 2.8 actually.

@Mindavi
Copy link
Contributor

Mindavi commented May 23, 2022

Because nix doesn't have a stable enough API yet, so building against latest nix occasionally fails. I prefer hydra not failing to build whever nix is bumped.

It's indeed on 2.8 now.

Feel free to locally override, with the sidenote that it'll inevitably fail to build one day.

@FlorianFranzen
Copy link
Contributor

FlorianFranzen commented May 23, 2022

Because nix doesn't have a stable enough API yet, so building against latest nix occasionally fails. I prefer hydra not failing to build whever nix is bumped.

I think hydra is important enough to be updated in parallel to nix, so not pinning it would make sure of that.

It's indeed on 2.8 now.

Right, I just realized the fix just has not hit unstable yet.

Feel free to locally override, with the sidenote that it'll inevitably fail to build one day.

We should not force people to build their own hydra just to have consistent nix behavior out of the box. So alternatively, to make the current scheme work, maybe we could passthru nix in the hydra expression, so that information is more easily accessible.

@lheckemann
Copy link
Member

I think hydra is important enough to be updated in parallel to nix, so not pinning it would make sure of that.

No, Hydra's development is generally based on an old version of Nix because Nix's development disregards Hydra. Hydra upstream pinned Nix 2.4 until recently. And the Hydra packaging in Nixpkgs is even less important than Hydra itself (hydra.nixos.org runs on Hydra master via flakes). :(

@FlorianFranzen
Copy link
Contributor

Hmm, ok. It would at least be nice to make that pin easily available then, so I proposed to add it to the passthru in #175452.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants