mprocs: init at 0.2.2 #174096
Merged
mprocs: init at 0.2.2 #174096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leixb
suggested changes
May 23, 2022
There was a problem hiding this comment.
Some comments on issues that to follow the guidelines. (https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md)
pkgs/tools/misc/mprocs/default.nix
Outdated
|
|
||
| meta = with lib; { | ||
| description = "mprocs runs multiple commands in parallel and shows output of each command separately."; | ||
| homepage = "https://github.com/BurntSushi/ripgrep"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/BurntSushi/ripgrep"; | |
| homepage = "https://github.com/pvolok/mprocs"; |
pkgs/tools/misc/mprocs/default.nix
Outdated
| src = fetchFromGitHub { | ||
| owner = "pvolok"; | ||
| repo = pname; | ||
| rev = "refs/tags/v${version}"; |
There was a problem hiding this comment.
I don't think refs/tags is needed
Suggested change
| rev = "refs/tags/v${version}"; | |
| rev = "v${version}"; |
pkgs/tools/misc/mprocs/default.nix
Outdated
| cargoSha256 = "sha256-vGhoM5VMJO+ppLk8DetNZ8UteU6ifdtRe1HNJ0dSB+0="; | ||
|
|
||
| meta = with lib; { | ||
| description = "mprocs runs multiple commands in parallel and shows output of each command separately."; |
There was a problem hiding this comment.
meta.descriptionshould:- Be capitalized.
- Not start with the package name.
- Not have a period at the end.
Check https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
|
Result of 1 package built:
|
|
Thank you @Leixb for your feedback ! |
|
@Leixb I have fixed the way I committed this PR. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Leixb
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
mprocs runs multiple commands in parallel and shows output of each command separately.
Project homepage: https://github.com/pvolok/mprocs
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes