Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimPackages.zippy: 0.7.3 -> 0.9.9 #176342

Closed
wants to merge 1 commit into from
Closed

nimPackages.zippy: 0.7.3 -> 0.9.9 #176342

wants to merge 1 commit into from

Conversation

erdnaxe
Copy link
Contributor

@erdnaxe erdnaxe commented Jun 5, 2022

Description of changes

Motivation: Nitter is now using 0.9.9 (#176279)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@erdnaxe erdnaxe requested a review from ehmry as a code owner June 5, 2022 07:44
@github-actions github-actions bot added the 6.topic: nim Nim programing language label Jun 5, 2022
@erdnaxe
Copy link
Contributor Author

erdnaxe commented Jun 5, 2022

guzba/zippy@8c43184#diff-b0b12455b57f6771854b714d05f40560590a4a70f6e4a92ff8d8bd62db7b9d77R5 is problematic as the test_ziparchives no longer extracts to a temporary directory.

@erdnaxe erdnaxe mentioned this pull request Jun 5, 2022
Closed
@erdnaxe erdnaxe changed the title zippy: 0.7.3 -> 0.9.9 nimPackages.zippy: 0.7.3 -> 0.9.9 Jun 5, 2022
@ehmry
Copy link
Contributor

ehmry commented Jun 6, 2022

zedeus/nitter@d407051

@erdnaxe
Copy link
Contributor Author

erdnaxe commented Jun 6, 2022

Ok so I believe we should rather keep the old version then. Thanks!

@erdnaxe erdnaxe closed this Jun 6, 2022
@guzba
Copy link

guzba commented Jun 9, 2022

Just a note that the issue in zippy noted above has been resolved in zippy 0.9.11. See zedeus/nitter@5cceca4 and guzba/zippy#45

@erdnaxe erdnaxe mentioned this pull request Jun 10, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
6.topic: nim Nim programing language 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erdnaxe @ehmry @guzba