haskellPackages.clash-prelude: fix build by disabling tests #178868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
requested review from
cdepillabout,
sternenseemann and
maralorn
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
| @@ -2604,4 +2604,7 @@ in { | |||
| purescript-ast = purescriptBrokenFlag (super.purescript-ast.overrideScope purescriptOverlay); | |||
|
|
|||
| purenix = super.purenix.overrideScope purescriptOverlay; | |||
|
|
|||
| # tests use doctest-parallel which produces some errors during testing | |||
There was a problem hiding this comment.
A couple things:
- Could you rebase this on the
haskell-updatesbranch? We generally ask that all haskell-related PRs go to that branch. - Are you sure that these doctests are failing because of some Nix/sandbox related reason, and not because they are actually broken for some reason? Do you know why they are broken? Does it make sense to have an upstream issue tracking this?
- It looks like
clash-preludeis inpkgs/development/haskell-modules/configuration-hackage2nix/transitive-broken.yaml. Could you remove it from that list and confirm that it no longer depends on any packages that are marked broken?
There was a problem hiding this comment.
I did points 1 and 3. Regarding 2, I'm not really sure why the tests fail, it was not straightforward and I didn't have time to investigate.
There was a problem hiding this comment.
@cdepillabout is there anything more I need to do?
There was a problem hiding this comment.
This should be available in master when #181822 is merged in.
ofborg
bot
added
8.has: package (new)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes