Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomecast: 1.9.11 -> unstable-2022-04-23 #180342

Merged
merged 1 commit into from
Apr 11, 2023
Merged

gnomecast: 1.9.11 -> unstable-2022-04-23 #180342

merged 1 commit into from
Apr 11, 2023

Conversation

MaeIsBad
Copy link
Contributor

@MaeIsBad MaeIsBad commented Jul 6, 2022 •
edited
Loading

The gnomecast pypi package is outdated(see: keredson/gnomecast#178) and doesn't work with the PyChromecast version in nixpkgs(keredson/gnomecast#171).
Without this commit gnomecast doesn't work at all, so if this PR is rejected I think gnomecast should be marked as broken.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@applePrincess
Copy link
Contributor

Result of nixpkgs-review pr 180342 run on x86_64-linux 1

1 package built:
  • gnomecast

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/843

SuperSandro2000
SuperSandro2000 reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a version upgrade the commit message is not fitting.

pkgs/applications/video/gnomecast/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/gnomecast/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

can you please rebase?

gnomecast: 1.9.11 -> 2022-04-23
fc365c2 
The gnomecast pypi package is
outdated(see: keredson/gnomecast#178)
and doesn't work with the PyChromecast version in
nixpkgs(keredson/gnomecast#171).
@MaeIsBad
Copy link
Contributor Author

done

@SuperSandro2000 SuperSandro2000 changed the title gnomecast: fetch from git instead of pypi gnomecast: 1.9.11 -> unstable-2022-04-23 Apr 11, 2023
@SuperSandro2000 SuperSandro2000 merged commit e7c6a07 into NixOS:master Apr 11, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaeIsBad @applePrincess @nixos-discourse @SuperSandro2000 @Janik-Haag