go_1_19: init at 1.19

[zowoq]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

https://go.dev/doc/go1.19

[zowoq]

creds-test.patch was upstreamed.

 stdenv.mkDerivation rec {
   pname = "go";
-  version = "1.18.4";
+  version = "1.19rc2";
 
   src = fetchurl {
     url = "https://go.dev/dl/go${version}.src.tar.gz";
-    sha256 = "sha256-RSWqaw487LV4RfQGCnB1qvyat1K7e2tM+KIS1DB44eQ=";
+    sha256 = "sha256-xo1wGaaguYUq4Oltfn3rdySSojJy/W0Tr+BbQMkS5Rs=";
   };
 
   strictDeps = true;
@@ -176,11 +176,10 @@
     ./remove-tools-1.11.patch
     ./ssl-cert-file-1.16.patch
     ./remove-test-pie-1.15.patch
-    ./creds-test.patch
     ./skip-chown-tests-1.16.patch
     ./skip-external-network-tests-1.16.patch
     ./skip-nohup-tests.patch
-    ./skip-cgo-tests-1.15.patch
+    ./skip-cgo-tests-1.19.patch
     ./go_no_vendor_checks-1.16.patch
   ];
 

[SuperSandro2000]

I think we should take this opportunity to convert the file into a generic one. Copying it with every new go release just duplicates code.

[SuperSandro2000]

Do we really need thi?

[zowoq]

Do we really need thi?

If you are asking if we need buildGo119Package, as long as we are still using buildGoPackage we need a versioned equivalent.

[zowoq]

I think we should take this opportunity to convert the file into a generic one. Copying it with every new go release just duplicates code.

This has been discussed before and the go maintainers were fine with the status quo. Even if we do decide to switch to a generic style derivation it doesn't need to happen now.

[zimbatm]

Result of nixpkgs-review pr 181797 run on x86_64-linux 1

1 package built:

• go_1_19

[Mic92]

I think we should take this opportunity to convert the file into a generic one. Copying it with every new go release just duplicates code.

This has been discussed before and the go maintainers were fine with the status quo. Even if we do decide to switch to a generic style derivation it doesn't need to happen now.

Yeah with 2-3 go derivations is just simply easier to only have too look at one file rather than a generic function and one per go version.

[xvello]

Thanks for the packaging work @zowoq! Do you know whether this will be backported in 22.05 or not?

[Mic92]

@xvello I don't see why not. Feel to create a backport PR.

[xvello]

Thanks, I'll look into how to do so.