arcanist: pin php to 8.0 #182364
Merged
arcanist: pin php to 8.0 #182364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
approved these changes
Jul 23, 2022
jonringer-comm
pushed a commit
to CommE2E/comm
that referenced
this pull request
Jul 28, 2022
Summary: Update the dev shell. This also includes the changes from NixOS/nixpkgs#182364 which fixes arcanist. Arcanist is passing on official nix cache: https://hydra.nixos.org/eval/1773081?filter=arcanist&compare=1773037&full=#tabs-still-succeed so it's available for all platforms The pruned node patch is only relevant for environments which are missing `$HOME` (e.g. nix's sandbox builds), but shouldn't affect dev workflow. Also, may not be relevant, as patch fails to apply as it's "already applied". Depends on D4660 Test Plan: `nix develop` Reviewers: varun, ashoat Subscribers: tomek, adrian, atul, abosh Differential Revision: https://phab.comm.dev/D4646
jonringer-comm
pushed a commit
to CommE2E/comm
that referenced
this pull request
Jul 29, 2022
Summary: Update the dev shell. This also includes the changes from NixOS/nixpkgs#182364 which fixes arcanist. Arcanist is passing on official nix cache: https://hydra.nixos.org/eval/1773081?filter=arcanist&compare=1773037&full=#tabs-still-succeed so it's available for all platforms The pruned node patch is only relevant for environments which are missing `$HOME` (e.g. nix's sandbox builds), but shouldn't affect dev workflow. Also, may not be relevant, as patch fails to apply as it's "already applied". Test Plan: `nix develop` Reviewers: varun, ashoat Reviewed By: ashoat Subscribers: tomek, adrian, atul, abosh Differential Revision: https://phab.comm.dev/D4646
jonringer-comm
pushed a commit
to CommE2E/comm
that referenced
this pull request
Jul 29, 2022
Summary: Since NixOS/nixpkgs#182364 was merged, this behavior is now the default in nixpkgs. We no longer need to provide an override to change the behavior. Test Plan: ``` # this can be used from any branch nix develop github:commE2E/comm?ref=update-nix-flakes # use any arc command, 8.1 would fail on `arc diff` ``` Reviewers: varun Reviewed By: varun Subscribers: ashoat, tomek, adrian, atul, abosh Differential Revision: https://phab.comm.dev/D4661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Not all strnull callsites have been patched yet: https://secure.phabricator.com/D21853, use php 8.0 which only emits warnings, instead of php8.1's hard crashes.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes