Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hclfmt: init at 2.12.0 #182472

Merged
merged 3 commits into from
Jul 25, 2022
Merged

hclfmt: init at 2.12.0 #182472

merged 3 commits into from
Jul 25, 2022

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jul 22, 2022

Description of changes

new package!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm mentioned this pull request Jul 22, 2022
Closed
@zimbatm zimbatm requested a review from flokli July 22, 2022 16:26
winterqt
winterqt requested changes Jul 24, 2022
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor formatting changes. Looks good otherwise, though!

pkgs/development/tools/hclfmt/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hclfmt/default.nix Outdated Show resolved Hide resolved
zimbatm and others added 2 commits July 25, 2022 12:58
@zimbatm @winterqt
Update pkgs/development/tools/hclfmt/default.nix
d4f4d3f 
Co-authored-by: Winter <winter@winter.cafe>
@zimbatm @winterqt
Update pkgs/development/tools/hclfmt/default.nix
c8f12b3 
Co-authored-by: Winter <winter@winter.cafe>
@zimbatm zimbatm requested a review from winterqt July 25, 2022 10:58
@zimbatm zimbatm merged commit eb5ea15 into NixOS:master Jul 25, 2022
@zimbatm zimbatm deleted the hclfmt-2.12.0 branch July 25, 2022 18:16
@zowoq
Copy link
Contributor

zowoq commented Jul 25, 2022 •
edited
Loading

Would have be good to either fix the darwin builds or mark them as broken ...

#182880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@winterqt winterqt Awaiting requested review from winterqt

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zimbatm @zowoq @winterqt