deadpixi-sam: init at 2016-09-15 #18305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
upstreamed the packaging issues ( deadpixi/sam#21 ) so it's really working well and functioning properly now :) |
7 tasks
RamKromberg
changed the title
7 tasks
joachifm
requested changes
Sep 17, 2016
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/deadpixi/sam; |
There was a problem hiding this comment.
Note that you can do inherit (src.meta) homepage when using fetchFromGitHub.
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/deadpixi/sam; | ||
| description = " An updated version of the sam text editor. "; |
There was a problem hiding this comment.
Please remove superfluous whitespace and trailing punctuation, per the guidelines for meta.description.
| ''; | ||
|
|
||
| makeFlags = [ "DESTDIR=$(out)" ]; | ||
| buildInputs = [ freetype.dev libX11 libXt libXft ]; |
There was a problem hiding this comment.
I get the impression that freetype.dev is added here only because it is referenced in postPatch. If that is the case, you can safely remove it from build inputs.
RamKromberg
changed the title
joachifm
approved these changes
Sep 17, 2016
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A standalone updated sam.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)