Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubo: rename from ipfs #183349

Merged
merged 1 commit into from
Oct 3, 2022
Merged

kubo: rename from ipfs #183349

merged 1 commit into from
Oct 3, 2022

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jul 28, 2022

Description of changes

Go-IPFS was renamed to Kubo in version 0.14.0, see ipfs/kubo#8959.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 28, 2022
@Luflosi Luflosi requested a review from fabianhjr July 28, 2022 14:42
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jul 28, 2022
@ofborg ofborg bot requested review from fpletz, McSinyx and mguentner July 28, 2022 14:57
@McSinyx
Copy link
Member

McSinyx commented Jul 28, 2022 via email

@Luflosi
Copy link
Contributor Author

Luflosi commented Jul 28, 2022

Ok, if I'm already making such invasive changes as renaming the module, perhaps this would be a good time to rewrite the module and switch to an RFC42-style settings option. It might take a while before I get to finishing the rewrite.

@Luflosi Luflosi marked this pull request as draft July 28, 2022 23:35
@Luflosi Luflosi marked this pull request as ready for review August 20, 2022 23:21
@Luflosi
Copy link
Contributor Author

Luflosi commented Aug 20, 2022

I decided to only rename everything for now and not make any other changes.
Please review.

@ofborg ofborg bot requested a review from elitak August 20, 2022 23:30
fabianhjr
fabianhjr approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM,

Built on NixOS staging-next,

No file lost during naming change. :3

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 21, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/591

SuperSandro2000
SuperSandro2000 requested changes Aug 26, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing an alias for the module.

nixos/doc/manual/release-notes/rl-2211.section.md Outdated Show resolved Hide resolved
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@bobby285271 bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 16, 2022
@Luflosi Luflosi marked this pull request as draft September 16, 2022 20:11
@Luflosi Luflosi force-pushed the rename-ipfs-to-kubo branch 2 times, most recently from 4652dfe to d1ffabf Compare September 17, 2022 11:41
@Luflosi Luflosi marked this pull request as ready for review September 18, 2022 13:49
@Luflosi
Copy link
Contributor Author

Luflosi commented Sep 18, 2022

Please review.

@fabianhjr
Copy link
Member

LGTM, haven't noticed any issues.

Built and running on NixOS

@fpletz
Copy link
Member

fpletz commented Sep 27, 2022

Looks good. Thanks! Weird that they kept the ipfs binary name though.

@Luflosi Could you please rebase due to the conflict and I'll gladly merge this.

@Luflosi
Copy link
Contributor Author

Luflosi commented Sep 27, 2022

Weird that they kept the ipfs binary name though.

Yeah, I found renaming almost everything but not quite very confusing.

Could you please rebase due to the conflict and I'll gladly merge this.

Done.
I also updated the dates in pkgs/top-level/aliases.nix.

@ofborg ofborg bot requested a review from fpletz September 27, 2022 20:38
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 1, 2022
@Luflosi
Copy link
Contributor Author

Luflosi commented Oct 1, 2022

I'll fix the conflict tomorrow.

@bobby285271 bobby285271 added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 1, 2022
@Luflosi
kubo: rename from ipfs
eefaaf4 
Go-IPFS was renamed to Kubo in version 0.14.0, see ipfs/kubo#8959.
@Luflosi
Copy link
Contributor Author

Luflosi commented Oct 2, 2022

Done.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 2, 2022
@bobby285271 bobby285271 removed the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Oct 2, 2022
@SuperSandro2000 SuperSandro2000 merged commit b70049a into NixOS:master Oct 3, 2022
@Luflosi Luflosi deleted the rename-ipfs-to-kubo branch October 3, 2022 19:38
@Luflosi
Copy link
Contributor Author

Luflosi commented Oct 21, 2022

I'm converting it to RFC42-style settings in #197104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@fabianhjr fabianhjr fabianhjr approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@McSinyx McSinyx Awaiting requested review from McSinyx

@mguentner mguentner Awaiting requested review from mguentner

@elitak elitak Awaiting requested review from elitak

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Luflosi @McSinyx @nixos-discourse @fabianhjr @fpletz @SuperSandro2000 @bobby285271