stdenv: fix usage of native check inputs when using strictDeps, fixes… #185406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixOS#161570 In the past `checkInputs` were added to `nativeBuildInputs`. This was primarily done for convenience, since the introduction of `checkInputs` broke testing of Python packages (which already had the concept of `checkInputs`), and fixing all expressions directly was a hassle. Now we do the right thing, making sure `checkInputs` is added to `buildInputs` and also introducing `nativeCheckInputs` which is meant for things like hooks. Note this will require fixing all Python expressions using `checkInputs`. See NixOS#161570 for more details on this topic.
ofborg
bot
added
10.rebuild-darwin-stdenv
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #161570
In the past
checkInputswere added tonativeBuildInputs. This wasprimarily done for convenience, since the introduction of
checkInputsbroke testing of Python packages (which already had the concept of
checkInputs), and fixing all expressions directly was a hassle.Now we do the right thing, making sure
checkInputsis added tobuildInputsand also introducingnativeCheckInputswhich is meantfor things like hooks.
Note this will require fixing all Python expressions using
checkInputs.See #161570 for more details on this topic.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes