-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-publish: init at 1.8.1 #190309
git-publish: init at 1.8.1 #190309
Conversation
Undrafted, I think I'll be using this enough that I can maintain it :) |
pkgs/applications/version-management/git-and-tools/git-publish/default.nix
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-publish/default.nix
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-publish/default.nix
Outdated
Show resolved
Hide resolved
{ lib, stdenv, python, perl, fetchFromGitHub }: | ||
stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ lib, stdenv, python, perl, fetchFromGitHub }: | |
stdenv.mkDerivation rec { | |
{ lib, stdenv, python, perl, fetchFromGitHub }: | |
stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a written convention for this now? If not I won't apply this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teto How about you are not being passive aggressive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lheckemann we do not have written rules for literally everything and I don't want to write rules for everything. It would make it a lot easier if you could just incorporate style changes together with the other 3 changes. If it would be the only comment then I would have completely ignored it. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is: I prefer the style that I wrote. As long as we don't have a rule saying what the preferred variant is to resolve matters of pure opinion like this, I don't think it makes sense to have these discussions.
I'm grateful for your reviews that bring my attention to useful things like installManPage
-- I think we can all agree that using abstractions like this where they exist makes sense.
But things that are matters of pure opinion, like this blank line here, are a waste of time. I'd appreciate if you could limit yourself to the actually useful things -- or policies that are actually written somewhere, so i don't have to guess what "SuperSandro2000-conforming style" is -- in future reviews of my code.
8e21bb4
to
b94a993
Compare
b94a993
to
65e03bd
Compare
@lheckemann can you activate that maintainer can push to your branch? That makes things a lot easier and faster to merge. |
Description of changes
Init package.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes