Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstack: init at unstable-2021-01-26 #190335

Closed
wants to merge 1 commit into from

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Sep 8, 2022

Description of changes

Draft, since I'm not sure I'll be using this enough to be able to maintain it, in hopes that anyone else who wants it can start from here and not from scratch.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Comment on lines +1 to +2
{ stdenv, lib, fetchFromGitHub, fetchpatch, cmake, pkg-config, libiberty, libelf, binutils-unwrapped, zlib }:
stdenv.mkDerivation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, lib, fetchFromGitHub, fetchpatch, cmake, pkg-config, libiberty, libelf, binutils-unwrapped, zlib }:
stdenv.mkDerivation {
{ stdenv, lib, fetchFromGitHub, fetchpatch, cmake, pkg-config, libiberty, libelf, binutils-unwrapped, zlib }:
stdenv.mkDerivation {

Comment on lines +6 to +24
nativeBuildInputs = [ cmake pkg-config ];

buildInputs = [ libiberty libelf binutils-unwrapped zlib ];

src = fetchFromGitHub {
owner = "yoshinorim";
repo = "quickstack";
rev = "b853629a55fb7494b40c3bc52c743b428c73e39e";
sha256 = "1jzl37rmipk8n9s5sl8xrp1bhxgc0607qcpn74px0dli2xm9cvb2";
};

patches = [
(fetchpatch {
# Submitted upstream: https://github.com/yoshinorim/quickstack/pull/14
name = "find-deps-better.patch";
url = "https://github.com/lheckemann/quickstack/commit/c6bc165e6ea3c03af8769f216f9f437d9021257b.patch";
sha256 = "sha256-uCG75XAQQLcnye9S/MeIP77xhIVFOrF5MIni0941LVs=";
})
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ cmake pkg-config ];
buildInputs = [ libiberty libelf binutils-unwrapped zlib ];
src = fetchFromGitHub {
owner = "yoshinorim";
repo = "quickstack";
rev = "b853629a55fb7494b40c3bc52c743b428c73e39e";
sha256 = "1jzl37rmipk8n9s5sl8xrp1bhxgc0607qcpn74px0dli2xm9cvb2";
};
patches = [
(fetchpatch {
# Submitted upstream: https://github.com/yoshinorim/quickstack/pull/14
name = "find-deps-better.patch";
url = "https://github.com/lheckemann/quickstack/commit/c6bc165e6ea3c03af8769f216f9f437d9021257b.patch";
sha256 = "sha256-uCG75XAQQLcnye9S/MeIP77xhIVFOrF5MIni0941LVs=";
})
];
src = fetchFromGitHub {
owner = "yoshinorim";
repo = "quickstack";
rev = "b853629a55fb7494b40c3bc52c743b428c73e39e";
sha256 = "1jzl37rmipk8n9s5sl8xrp1bhxgc0607qcpn74px0dli2xm9cvb2";
};
patches = [
(fetchpatch {
# Submitted upstream: https://github.com/yoshinorim/quickstack/pull/14
name = "find-deps-better.patch";
url = "https://github.com/lheckemann/quickstack/commit/c6bc165e6ea3c03af8769f216f9f437d9021257b.patch";
sha256 = "sha256-uCG75XAQQLcnye9S/MeIP77xhIVFOrF5MIni0941LVs=";
})
];
nativeBuildInputs = [ cmake pkg-config ];
buildInputs = [ libiberty libelf binutils-unwrapped zlib ];

];

meta = {
description = "Tool for low-overhead stack traces";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing website

@lheckemann lheckemann closed this Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants