quickstack: init at unstable-2021-01-26#190335
Closed
lheckemann wants to merge 1 commit intoNixOS:masterfrom
Closed
quickstack: init at unstable-2021-01-26#190335lheckemann wants to merge 1 commit intoNixOS:masterfrom
lheckemann wants to merge 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
8.has: package (new)
Comment on lines
+1
to
+2
| { stdenv, lib, fetchFromGitHub, fetchpatch, cmake, pkg-config, libiberty, libelf, binutils-unwrapped, zlib }: | ||
| stdenv.mkDerivation { |
Member
There was a problem hiding this comment.
Suggested change
| { stdenv, lib, fetchFromGitHub, fetchpatch, cmake, pkg-config, libiberty, libelf, binutils-unwrapped, zlib }: | |
| stdenv.mkDerivation { | |
| { stdenv, lib, fetchFromGitHub, fetchpatch, cmake, pkg-config, libiberty, libelf, binutils-unwrapped, zlib }: | |
| stdenv.mkDerivation { |
Comment on lines
+6
to
+24
| nativeBuildInputs = [ cmake pkg-config ]; | ||
|
|
||
| buildInputs = [ libiberty libelf binutils-unwrapped zlib ]; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "yoshinorim"; | ||
| repo = "quickstack"; | ||
| rev = "b853629a55fb7494b40c3bc52c743b428c73e39e"; | ||
| sha256 = "1jzl37rmipk8n9s5sl8xrp1bhxgc0607qcpn74px0dli2xm9cvb2"; | ||
| }; | ||
|
|
||
| patches = [ | ||
| (fetchpatch { | ||
| # Submitted upstream: https://github.com/yoshinorim/quickstack/pull/14 | ||
| name = "find-deps-better.patch"; | ||
| url = "https://github.com/lheckemann/quickstack/commit/c6bc165e6ea3c03af8769f216f9f437d9021257b.patch"; | ||
| sha256 = "sha256-uCG75XAQQLcnye9S/MeIP77xhIVFOrF5MIni0941LVs="; | ||
| }) | ||
| ]; |
Member
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ cmake pkg-config ]; | |
| buildInputs = [ libiberty libelf binutils-unwrapped zlib ]; | |
| src = fetchFromGitHub { | |
| owner = "yoshinorim"; | |
| repo = "quickstack"; | |
| rev = "b853629a55fb7494b40c3bc52c743b428c73e39e"; | |
| sha256 = "1jzl37rmipk8n9s5sl8xrp1bhxgc0607qcpn74px0dli2xm9cvb2"; | |
| }; | |
| patches = [ | |
| (fetchpatch { | |
| # Submitted upstream: https://github.com/yoshinorim/quickstack/pull/14 | |
| name = "find-deps-better.patch"; | |
| url = "https://github.com/lheckemann/quickstack/commit/c6bc165e6ea3c03af8769f216f9f437d9021257b.patch"; | |
| sha256 = "sha256-uCG75XAQQLcnye9S/MeIP77xhIVFOrF5MIni0941LVs="; | |
| }) | |
| ]; | |
| src = fetchFromGitHub { | |
| owner = "yoshinorim"; | |
| repo = "quickstack"; | |
| rev = "b853629a55fb7494b40c3bc52c743b428c73e39e"; | |
| sha256 = "1jzl37rmipk8n9s5sl8xrp1bhxgc0607qcpn74px0dli2xm9cvb2"; | |
| }; | |
| patches = [ | |
| (fetchpatch { | |
| # Submitted upstream: https://github.com/yoshinorim/quickstack/pull/14 | |
| name = "find-deps-better.patch"; | |
| url = "https://github.com/lheckemann/quickstack/commit/c6bc165e6ea3c03af8769f216f9f437d9021257b.patch"; | |
| sha256 = "sha256-uCG75XAQQLcnye9S/MeIP77xhIVFOrF5MIni0941LVs="; | |
| }) | |
| ]; | |
| nativeBuildInputs = [ cmake pkg-config ]; | |
| buildInputs = [ libiberty libelf binutils-unwrapped zlib ]; |
| ]; | ||
|
|
||
| meta = { | ||
| description = "Tool for low-overhead stack traces"; |
|
@lheckemann why is this closed? I'd address the review if needed |
Member
Author
|
I don't intend to maintain it. If you'd like to, you're welcome to take it and submit a new PR with yourself as the maintainer :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Draft, since I'm not sure I'll be using this enough to be able to maintain it, in hopes that anyone else who wants it can start from here and not from scratch.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes