Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ludusavi: init at 0.15.0 #190834

Merged
merged 1 commit into from
Nov 10, 2022
Merged

ludusavi: init at 0.15.0 #190834

merged 1 commit into from
Nov 10, 2022

Conversation

pasqui23
Copy link
Contributor

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

pkgs/applications/backup/ludusavi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/backup/ludusavi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/backup/ludusavi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/backup/ludusavi/default.nix Show resolved Hide resolved
@onny
Copy link
Contributor

onny commented Sep 12, 2022

Please squash commits :)

@SuperSamus
Copy link
Contributor

SuperSamus commented Oct 25, 2022

GUI doesn't work (simply typing ludusavi should open the GUI).
I made a branch that fixes the issue.
Not sure if some of the stuff should be only in either buldInputs or libPath (instead of both).
File picker doesn't work (not the biggest deal), don't know if it's related to Seeker14491/opener#4.

@pasqui23
Copy link
Contributor Author

pasqui23 commented Oct 25, 2022

I have tried @SuperSamus 's ludusavi package and while the gui runs I cannot select any window as soos as I click the directory select button I get:

immagine

And no output on std err.

@SuperSamus
Copy link
Contributor

Found the cause for the not working file picker, and fixed it. (Again, on my branch).
(BTW, don't forget to update the PR title)

@SuperSamus
Copy link
Contributor

I think that you need to squash the commits, and to rename the PR.

@pasqui23 pasqui23 changed the title ludusavi: init at 0.12.1 ludusavi: init at 0.14.0 Nov 3, 2022
@pasqui23 pasqui23 requested a review from azahi November 3, 2022 15:28
@SuperSamus
Copy link
Contributor

Just passing by to say that version 0.15.0 released.

@SuperSamus
Copy link
Contributor

You probably need to rebase, you are more than 17000 commits behind upstream master.
(And you need to rename the tile once again)

@pasqui23 pasqui23 changed the title ludusavi: init at 0.14.0 ludusavi: init at 0.15.0 Nov 10, 2022
Co-authored-by: Azat Bahawi <azat+github@bahawi.net>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1390

@SuperSandro2000 SuperSandro2000 merged commit 4c46529 into NixOS:master Nov 10, 2022
@pasqui23 pasqui23 deleted the ludusavi branch November 11, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants