Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

humility: init at unstable-2022-09-15 #192842

Merged
merged 2 commits into from
Sep 25, 2022
Merged

humility: init at unstable-2022-09-15 #192842

merged 2 commits into from
Sep 25, 2022

Conversation

therishidesai
Copy link
Contributor

Description of changes

Added the humility debugger for the hubris OS.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

danielfullmer
danielfullmer suggested changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've automatically reformatted all-packages.nix, which is making this PR huge. Try to make just the change needed for this PR without the automatic reformatting.

pkgs/development/tools/rust/humility/default.nix Show resolved Hide resolved
@therishidesai therishidesai changed the title added humility package humility: 0.0.1-nightly Sep 25, 2022
@therishidesai therishidesai changed the title humility: 0.0.1-nightly humility: init at 0.0.1-nightly Sep 25, 2022
AndersonTorres
AndersonTorres suggested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard! :)

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/rust/humility/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rust/humility/default.nix Outdated Show resolved Hide resolved
@therishidesai therishidesai changed the title humility: init at 0.0.1-nightly humility: init at unstable-09-15-2022 Sep 25, 2022
@AndersonTorres AndersonTorres changed the title humility: init at unstable-09-15-2022 humility: init at unstable-2022-09-15 Sep 25, 2022
@AndersonTorres AndersonTorres merged commit bc2035b into NixOS:master Sep 25, 2022
@alyssais
Copy link
Member

This doesn't eval with aliases disabled. Did OfBorg pass?

@alyssais alyssais mentioned this pull request Oct 30, 2022
Closed
13 tasks
@therishidesai
Copy link
Contributor Author

Yeah It looks like OfBorg passed

@tjni tjni mentioned this pull request Nov 6, 2022
Merged
13 tasks
SuperSandro2000 added a commit that referenced this pull request Nov 10, 2022
@SuperSandro2000
Merge pull request #199794 from tjni/fix-humility-hash
717ccac 
fixes #192842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfullmer danielfullmer danielfullmer requested changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@therishidesai @alyssais @danielfullmer @AndersonTorres