Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.debugpy: fix thread crashes in tests on aarch64-darwin #193254

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

fmoda3
Copy link
Contributor

@fmoda3 fmoda3 commented Sep 27, 2022

Description of changes

The python debugpy package fails to run tests properly on M1 machines. The fix outlined in this issue seems to solve the problem: #185289

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 27, 2022
@fmoda3 fmoda3 changed the title python3Packages.debugpy: fix thread crashes in tests on darwin-aarch64 python3Packages.debugpy: fix thread crashes in tests on aarch64-darwin Sep 27, 2022
@arkivm
Copy link
Contributor

arkivm commented Sep 28, 2022

An alternate solution is to set no_proxy = '*', which is the fix used by two other nixpkgs: check-jsonschema, pip-tools.
So, for consistency, let's switch to that solution.

Also, I don't quite understand why this should break only on aarch64-darwin. From the bug reports (python, pytest-parallel, cython), this seem to be a macos-wide issue. But hydra builds are fine for x86_64-darwin until the recent failure - which doesn't seem to be this issue. Might as well depend on the version of macOS running on these build systems.

@fmoda3
Copy link
Contributor Author

fmoda3 commented Sep 28, 2022

Sounds good. I tested it and the no_proxy solution seems to work as well. I changed the PR to use this solution.

Copy link
Contributor

@kira-bruneau kira-bruneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @fmoda3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants