Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.torch: fix by using older kernel headers #196571

Merged
merged 2 commits into from
Oct 20, 2022
Merged

python3Packages.torch: fix by using older kernel headers #196571

merged 2 commits into from
Oct 20, 2022

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Oct 18, 2022

https://hydra.nixos.org/build/195527156

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
linuxHeaders_5_19: init at 5.19.16
7993cdf 
Maybe multiple packages might use this temporarily,
e.g. due "flexible array member" errors - consequence of:
torvalds/linux@94dfc73
@vcunat
python3Packages.torch: fix by using older kernel headers
87d9283
@vcunat vcunat mentioned this pull request Oct 18, 2022
Merged
13 tasks
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 18, 2022
@vcunat vcunat merged commit ad9975e into NixOS:staging-next Oct 20, 2022
@vcunat
Copy link
Member Author

vcunat commented Oct 20, 2022

Let me merge early so that we progress. This isn't getting to master immediately anyway.

@vcunat vcunat deleted the p/python-torch branch October 20, 2022 05:56
wegank added a commit to wegank/nixpkgs that referenced this pull request Dec 31, 2022
@wegank
python3Packages.torch: revert NixOS#196571 on darwin
e736247
github-actions bot pushed a commit that referenced this pull request Jan 6, 2023
@wegank @github-actions
python3Packages.torch: revert #196571 on darwin
bcd1785 
(cherry picked from commit e736247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@teh teh Awaiting requested review from teh

@tscholak tscholak Awaiting requested review from tscholak

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vcunat