Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, nex: init at unstable #198963

Merged
merged 2 commits into from
Jan 10, 2023
Merged

mgmt, nex: init at unstable #198963

merged 2 commits into from
Jan 10, 2023

Conversation

urandom2
Copy link
Contributor

@urandom2 urandom2 commented Nov 1, 2022

Description of changes

This change adds two packages: mgmt and nex. The latter is a build dependency for the former. Unfortunately both do not have stable releases, thus each tracks the tip of their respective upstream branches. Go module pseudo versions are used.

mgmt: Next generation distributed, event-driven, parallel config management!
nex: Lexer for Go

Fixes #98458 purpleidea/mgmt#610

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@urandom2 urandom2 changed the title mgmt, nex: init at unstable mgmt, nex: init at latest Nov 1, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1342

pkgs/development/tools/parsing/nex/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/parsing/nex/default.nix Outdated Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1373

@urandom2 urandom2 changed the title mgmt, nex: init at latest mgmt, nex: init at unstable Nov 7, 2022
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails with make: /usr/bin/env: No such file or directory which means the program env tries to launch does not exist.

pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/system/mgmt/default.nix Outdated Show resolved Hide resolved
@urandom2
Copy link
Contributor Author

urandom2 commented Nov 7, 2022

this is what I was commenting about back here, #198963 (comment), but after rerunning things it works on my system and produces /nix/store/l8gi44nywd0dsqfwsh7wfvz37787acgy-mgmt-unstable-2022-10-24.

with my latest changes applied, does this not work for you?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1416

@SuperSandro2000
Copy link
Member

with my latest changes applied, does this not work for you?

I didn't test it on my machine but ofborg failed with that and ofborg has the final say.

@urandom2
Copy link
Contributor Author

ah, sweet; I was just having trouble reproducing the failure, and that is the pointer I needed!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1471

@gador
Copy link
Contributor

gador commented Nov 27, 2022

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 198963 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • mgmt: log was empty
1 package built:
  • nex

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

mgmt:

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/applications/system/mgmt/default.nix:69:5:

   |
69 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: unused-argument
Unused argument: bash.
Near pkgs/applications/system/mgmt/default.nix:2:3:

  |
2 | , bash
  |   ^
nex:

got build log for '/nix/store/dvqp804qlqwgsfqvpfafmvk540xjjc1b-nex-unstable-2021-03-30' from 'daemon'
When evaluating attribute ‘nex’:
warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/development/tools/parsing/nex/default.nix:24:5:

   |
24 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1483

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1518

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1541

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1571

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1605

@SuperSandro2000
Copy link
Member

Please rebase

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1653

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1683

@SuperSandro2000 SuperSandro2000 merged commit ede4823 into NixOS:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFP: mgmtconfig
4 participants