Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceDependency: fix syntax error #19939

Merged
merged 1 commit into from
Dec 30, 2016
Merged

replaceDependency: fix syntax error #19939

merged 1 commit into from
Dec 30, 2016

Conversation

groxxda
Copy link
Contributor

@groxxda groxxda commented Oct 27, 2016

Motivation for this change

This is parsed as an uri instead of a lambda like it's intended.

Since the error was there from the beginning (given that uri parsing existed one year ago), that code path was almost certainly never used and could as well be removed.

cc @shlevy @oconnorr

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@groxxda, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oconnorr, @shlevy and @roconnor to be potential reviewers.

@shlevy
Copy link
Member

shlevy commented Oct 27, 2016

@roconnor I think you added the verbosity stuff, OK with just removing the verbose param?

@7c6f434c 7c6f434c merged commit dd2fc99 into NixOS:master Dec 30, 2016
@groxxda groxxda deleted the replaceDependency branch September 21, 2017 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants