Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arangod: tidy maintainers, preConfigure #200210

Merged
merged 2 commits into from
Nov 11, 2022
Merged

arangod: tidy maintainers, preConfigure #200210

merged 2 commits into from
Nov 11, 2022

Conversation

jsoo1
Copy link
Contributor

@jsoo1 jsoo1 commented Nov 8, 2022

Description of changes

Missed code review feedback.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure
681d8b4 
Missed code review feedback.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@jsoo1 jsoo1 mentioned this pull request Nov 8, 2022
Merged
13 tasks
@ofborg ofborg bot requested a review from flosse November 8, 2022 15:04
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2022
@vcunat
Copy link
Member

vcunat commented Nov 8, 2022

When doing this, you might well order preConfigure after postPatch, as that's the order they get executed.

@jsoo1
Copy link
Contributor Author

jsoo1 commented Nov 8, 2022

@vcunat I reordered them. Thank you!

@SuperSandro2000 SuperSandro2000 merged commit 6d83b97 into NixOS:master Nov 11, 2022
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Nov 11, 2022
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
892db06 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@jsoo1 jsoo1 deleted the jsoo1/arangodb-code-review branch December 6, 2022 15:07
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Dec 14, 2022
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
4b59aec 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Jun 1, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
2839e13 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Jul 14, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
c3a4952 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Jul 21, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
5be7302 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Aug 7, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
b73b8ed 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Sep 7, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
92f571f 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
rtimush pushed a commit to rtimush/nixpkgs that referenced this pull request Sep 21, 2023
@jsoo1 @SuperSandro2000 @rtimush
arangod: tidy maintainers, preConfigure (NixOS#200210)
c9e83fc 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Oct 20, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
899e77c 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Dec 14, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
e3cd2be 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Dec 21, 2023
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
d0c25ed 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jsoo1 added a commit to awakesecurity/nixpkgs that referenced this pull request Jan 13, 2024
@jsoo1 @SuperSandro2000
arangod: tidy maintainers, preConfigure (NixOS#200210)
44c3c71 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flosse flosse Awaiting requested review from flosse

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoo1 @vcunat @SuperSandro2000