-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
efivar: fix build on i686, use clickable homepage #200916
Conversation
Maybe at least do this conditionally, so that QA isn't lowered on the main platforms? |
If the build would fail on x84_64 because of a warning and Werror we would ignore, too, so that wouldn't change much. |
If the current error happened on |
I wouldn't especially if it is some c specific memory overflow because I do not know anything about C except that you need to manually do memory management and there are lots of bugs about that. |
Well sure, pure C is the main language in my paid job... but it depends on particular error – these looked easy to fix (at quick glance at least). |
Seems to be fixed upstream, am testing if it backports: |
See [1] and [2]. [1]: NixOS#198789 [2]: NixOS#200916
Backport PR: #200964 |
See [1] and [2]. [1]: NixOS#198789 [2]: NixOS#200916
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes