Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.bigmemory: fix evaluation on darwin #202645

Merged
merged 1 commit into from
Nov 24, 2022
Merged

rPackages.bigmemory: fix evaluation on darwin #202645

merged 1 commit into from
Nov 24, 2022

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 24, 2022

Description of changes

On Darwin pkgs.libuuid is null, hence evaluating .dev fails.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@marsam
rPackages.bigmemory: fix evaluation on darwin
e76e9ed 
On Darwin pkgs.libuuid is null, hence evaluating `.dev` fails.
@marsam marsam requested a review from jbedo as a code owner November 24, 2022 06:48
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Nov 24, 2022
@jbedo jbedo merged commit c2820ac into NixOS:master Nov 24, 2022
@firestack firestack mentioned this pull request Dec 4, 2022
Closed
@github-actions github-actions bot mentioned this pull request Dec 4, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

Successfully created backport PR #204396 for release-22.11.

@marsam marsam deleted the fix-eval-rPackages.bigmemory branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedo jbedo jbedo approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsam @jbedo @Artturin