Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bspwm module: refactor #20384

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Conversation

ericsagnes
Copy link
Contributor

Motivation for this change

Make bspwm module more "standard", and avoid duplication of code.

Contents:

  • removal of bspwm-unstable module in favor of services.xserver.windowManager.bspwm.package
  • new options:
    • bspwm.package to select which bspwm package to use
    • bspwm.configFile to set the bspwm configuration file
    • bspwm.sxhkd.package to select which sxhkd package to use
    • bspwm.sxhkd.configFile to set the sxhkd configuration file
  • removal of startThroughSession and sessionScript options as ${pkgs.bspwm}/bin/bspwm-session does not exists anymore

cc @cedeel @Adjective-Object

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ericsagnes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cedeel, @Adjective-Object and @meisternu to be potential reviewers.

@fmthoma fmthoma mentioned this pull request Nov 16, 2016
7 tasks
@joachifm joachifm merged commit 2c01da3 into NixOS:master Nov 17, 2016
@ericsagnes
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants