nixos/tmp: move /tmp options under boot.tmp #204534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
SuperSandro2000
force-pushed
the
boot-tmp
branch
from
da973a4
to
d33740d
Compare
Scrumplex
reviewed
Mar 18, 2023
nixos/modules/system/boot/tmp.nix
Outdated
| type = types.bool; | ||
| default = false; | ||
| description = lib.mdDoc '' | ||
| Whether to delete all files in {file}`/tmp` during boot. | ||
| ''; | ||
| }; | ||
|
|
||
| boot.tmpOnTmpfs = mkOption { | ||
| boot.tmp.onTmpfs = mkOption { | ||
| type = types.bool; | ||
| default = false; | ||
| description = lib.mdDoc '' | ||
| Whether to mount a tmpfs on {file}`/tmp` during boot. |
There was a problem hiding this comment.
Maybe we can use this opportunity to also inform about side effects, such as large builds (like the kernel) failing if there isn't enough space?
Last time I tried, a 16GB tmpfs wasn't enough space to build a kernel using Nix.
There was a problem hiding this comment.
If you have a suggestion feel free to provide an improved text.
Scrumplex
approved these changes
Mar 18, 2023
Scrumplex
reviewed
Mar 18, 2023
nixos/modules/system/boot/tmp.nix
Outdated
| type = types.bool; | ||
| default = false; | ||
| description = lib.mdDoc '' | ||
| Whether to delete all files in {file}`/tmp` during boot. | ||
| ''; | ||
| }; | ||
|
|
||
| boot.tmpOnTmpfs = mkOption { | ||
| boot.tmp.onTmpfs = mkOption { |
There was a problem hiding this comment.
Suggestion: boot.tmp.mountTmpfs
There was a problem hiding this comment.
I forget to push that yesterday but I already renamed it to useTmpfs.
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
SuperSandro2000
force-pushed
the
boot-tmp
branch
from
d33740d
to
a5d95ac
Compare
Scrumplex
reviewed
Mar 20, 2023
Scrumplex
approved these changes
Mar 20, 2023
MartinNikov
added a commit
to MartinNikov/arion
that referenced
this pull request
Aug 22, 2023
…ad of `boot.tmpOnTmpfs` This change fixes the following warning: ``` trace: Obsolete option `boot.tmpOnTmpfs' is used. It was renamed to `boot.tmp.useTmpfs'. ``` This option was renamed in this PR: NixOS/nixpkgs#204534
bors bot
added a commit
to hercules-ci/arion
that referenced
this pull request
Aug 23, 2023
211: fix(modules/service/nixos-init): Use `boot.tmp.useTmpfs` option instead of `boot.tmpOnTmpfs` r=roberth a=MartinNikov This change fixes the following warning: ``` trace: Obsolete option `boot.tmpOnTmpfs' is used. It was renamed to `boot.tmp.useTmpfs'. ``` This option was renamed in this PR: NixOS/nixpkgs#204534 Co-authored-by: MartinNikov <99672862+MartinNikov@users.noreply.github.com>
ciarandg
pushed a commit
to ciarandg/arion
that referenced
this pull request
Dec 17, 2023
…ad of `boot.tmpOnTmpfs` This change fixes the following warning: ``` trace: Obsolete option `boot.tmpOnTmpfs' is used. It was renamed to `boot.tmp.useTmpfs'. ``` This option was renamed in this PR: NixOS/nixpkgs#204534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for suggestions for better names
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes