v2raya: init at 2.0.0 #204807
Merged
v2raya: init at 2.0.0 #204807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
8.has: package (new)
Eliot00
force-pushed
the
v2raya-init
branch
2 times, most recently
from
90266fe
to
77994c9
Compare
zendo
approved these changes
Dec 8, 2022
Eliot00
force-pushed
the
v2raya-init
branch
2 times, most recently
from
bc88fac
to
819d547
Compare
zendo
approved these changes
Dec 8, 2022
ofborg
bot
added
10.rebuild-darwin: 0
zendo
approved these changes
Dec 10, 2022
|
v2.0.0 is out: https://github.com/v2rayA/v2rayA/releases/tag/v2.0.0 |
Eliot00
force-pushed
the
v2raya-init
branch
2 times, most recently
from
d600d28
to
50e9558
Compare
bobby285271
changed the title
Update nixos/modules/services/networking/v2raya.nix Co-authored-by: zendo <linzway@qq.com> Update nixos/modules/services/networking/v2raya.nix Co-authored-by: zendo <linzway@qq.com> Update pkgs/tools/networking/v2raya/default.nix Co-authored-by: zendo <linzway@qq.com> Update pkgs/tools/networking/v2raya/default.nix Co-authored-by: zendo <linzway@qq.com> Update nixos/modules/services/networking/v2raya.nix Co-authored-by: zendo <linzway@qq.com> Update pkgs/tools/networking/v2raya/default.nix Co-authored-by: zendo <linzway@qq.com> Update nixos/modules/services/networking/v2raya.nix Co-authored-by: zendo <linzway@qq.com>
| dontFixup = true; | ||
| }; | ||
| in | ||
| buildGoModule { |
There was a problem hiding this comment.
Some new lines wouldn't hurt to increase readability
Comment on lines
+58
to
+61
| --prefix XDG_DATA_DIRS ":" ${symlinkJoin { | ||
| name = "assets"; | ||
| paths = [ v2ray-geoip v2ray-domain-list-community ]; | ||
| }}/share |
There was a problem hiding this comment.
Big inlines like this are not that readable, it should be done in a let in
| }; | ||
| }; | ||
|
|
||
| config = mkIf config.services.v2raya.enable { |
There was a problem hiding this comment.
I doubt that this service has no options
| unitConfig = { | ||
| Description = "v2rayA service"; | ||
| Documentation = "https://github.com/v2rayA/v2rayA/wiki"; | ||
| After = [ "network.target" "nss-lookup.target" "iptables.service" "ip6tables.service" ]; |
There was a problem hiding this comment.
This will break if ipv6 is disabled.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #158554
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes