Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] forgejo: init at 1.18.0-rc1-1 #206493

Closed
wants to merge 1 commit into from

Conversation

Infinidoge
Copy link
Contributor

Description of changes

Forgejo is a new fork of Gitea by the people at Codeberg, designed to try and make a new place where the Gitea community can come together and control their project again. Codeberg themselves have stated that once Forgejo releases its first stable version, they will be switching over.

Forgejo is a soft-fork as of currently, so it shares the vast majority of its code base with Gitea, so most of the work done in this PR is just duplicating the existing things for Gitea and editing text. That being said, since Forgejo has not yet released its first stable release, I intend on keeping this PR as a draft until that happens. (Also allows for time for feedback, and for making finishing touches.)

Announcement Blog Posts:
https://blog.codeberg.org/codeberg-launches-forgejo.html
https://forgejo.org/2022-12-15-hello-forgejo/

TODO
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 17, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 17, 2022
description = "Beyond coding. We forge.";
homepage = "https://forgejo.org";
license = licenses.mit;
maintainers = with maintainers; [ disassembler kolaente ma27 techknowlogick ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add me as maintainer in new packages without asking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second this.

Copy link
Contributor Author

@Infinidoge Infinidoge Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, whoops, I changed the maintainers on the module but forgot to on the package.
Fixed. If you do want to be added as maintainers, let me know.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 17, 2022
@RaitoBezarius RaitoBezarius mentioned this pull request Dec 24, 2022
@adamcstephens
Copy link
Contributor

1.18.0-1 is now released. https://codeberg.org/forgejo/forgejo/releases/tag/v1.18.0-1

@adamcstephens
Copy link
Contributor

Actually this package had already been merged in #207796

@trepetti
Copy link
Contributor

trepetti commented Jan 14, 2023

Actually this package had already been merged in #207796

That PR didn't have the service, however. Would it be possible to rebase this to after the base package got merged to keep the service functionality?

@adamcstephens
Copy link
Contributor

I agree we should have a separate module for Forgejo as well, sorry I missed this had that functionality. For now you should be able to use services.gitea.package = pkgs.forgeo

@Infinidoge Infinidoge changed the title [DRAFT] forgejo: init at 1.18.0-rc1-1 nixos/forgejo: init Jan 14, 2023
@Infinidoge Infinidoge changed the title nixos/forgejo: init [DRAFT] forgejo: init at 1.18.0-rc1-1 Jan 14, 2023
@Infinidoge
Copy link
Contributor Author

Went ahead and did the rebase and pulled out specifically the service functionality.
Was doing to rename and reopen this PR, but I can't actually reopen it, so I'm going to go ahead and make a new PR.

@Infinidoge Infinidoge mentioned this pull request Jan 14, 2023
13 tasks
@sagar-chandarana
Copy link

I agree we should have a separate module for Forgejo as well, sorry I missed this had that functionality. For now you should be able to use services.gitea.package = pkgs.forgeo

Hello Adam, as of now in nixOS v22.11, package forgejo is missing. Should I be using another system.stateVersion for forgejo? I am new to nixOS. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants