pam_rssh: init at unstable-2023-01-09 #209962
Closed
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
|
would be great if we had this! |
|
@woffs I updated the hashes and dropped the cargo patch as it's merged upstream. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1920 |
Comment on lines
+32
to
+40
| doCheck = false; | ||
| # How do disable specific tests? | ||
| # checkFlags = [ | ||
| # # Expects $USER and $SSH_AUTH_SOCK | ||
| # "--skip=lib::tests::sshagent_list_identities" | ||
| # "--skip=lib::tests::sshagent_auth" | ||
| # "--skip=lib::tests::sshagent_more_auth" | ||
| # "--skip=lib::tests::parse_user_authorized_keys" | ||
| # ]; |
There was a problem hiding this comment.
Suggested change
| doCheck = false; | |
| # How do disable specific tests? | |
| # checkFlags = [ | |
| # # Expects $USER and $SSH_AUTH_SOCK | |
| # "--skip=lib::tests::sshagent_list_identities" | |
| # "--skip=lib::tests::sshagent_auth" | |
| # "--skip=lib::tests::sshagent_more_auth" | |
| # "--skip=lib::tests::parse_user_authorized_keys" | |
| # ]; | |
| checkFlags = [ | |
| # Expects $USER and $SSH_AUTH_SOCK | |
| "--skip=test_sshagent_list_identities" | |
| "--skip=test_sshagent_auth" | |
| "--skip=test_sshagent_more_auth" | |
| "--skip=test_parse_user_authorized_keys" | |
| ]; |
that does not work?
There was a problem hiding this comment.
No, I get the following error:
Details
error: environment variable `SSH_AUTH_SOCK` not defined
--> src/lib.rs:198:42
|
198 | let mut agent = AgentClient::new(env!("SSH_AUTH_SOCK"));
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)
error: environment variable `SSH_AUTH_SOCK` not defined
--> src/lib.rs:213:42
|
213 | let mut agent = AgentClient::new(env!("SSH_AUTH_SOCK"));
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)
error: environment variable `SSH_AUTH_SOCK` not defined
--> src/lib.rs:235:42
|
235 | let mut agent = AgentClient::new(env!("SSH_AUTH_SOCK"));
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)
error: environment variable `USER` not defined
--> src/lib.rs:252:24
|
252 | let username = env!("USER");
| ^^^^^^^^^^^^
|
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)
There was a problem hiding this comment.
Can you prefixing the tests with test_?
There was a problem hiding this comment.
Same error message
|
@SuperSandro2000 I think this is ready for re-review, minus the tests. |
12 tasks
|
Implemented in ##237579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
An alternative to
pam_ssh_agent_auththat offers support for FIDO2/U2F keys (ECDSA-SK + ED25519-SK). Support inpam_ssh_agent_authhas stalled jbeverly/pam_ssh_agent_auth#23Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes