nixos/make-options-doc: use dummy store for XML conversion #211648
Conversation
Mirror of https://gitlab.com/rycee/nmd/-/merge_requests/10 `dummy://` was added in Nix 2.4, but since we use `pkgs.nix` directly this is not an issue. https://nixos.org/manual/nix/unstable/release-notes/rl-2.4.html
github-actions
bot
added
the
6.topic: nixos
|
is this urgent? if #211598 lands we're going to remove optionsXML and the stylesheets that process it before too long, and that should also obviate the need for nix here |
ofborg
bot
added
10.rebuild-darwin: 0
Not at all, I don't think anyone has reported an issue like nix-community/home-manager#3605 in nixpkgs.
I definitely want to review that soon ❤️ |
|
(How did you find this PR so fast 😅? Are you watching |
that's good at least. though thinking about the home-manager pr as it is, removing optionsXML is probably going to cause some disruption 🙁 guess we'll have to live with that, the removal of docbook is going to disrupt things one way or other.
❤️ can't wait to be done with docbook 😬
no, just coincidence. we check the pull request list occasionally when we're bored, and this time you came up first :D |
Well, not for home-manager since it's using NMD which has its own optionsXML. (Hence the need for this duplicate PR) |
|
not for home-manager, but potentially for other users of optionsXML. hopefully those don't even exist (and we're very inclined to call optionsJSON, optionsXML etc implementation details of the docs system). but the attribute has been exposed for a while and we don't know who uses it, so there's always a risk. in this case the risk is more likely on the side of just removing it and waiting for someone to complain than to keep it around for however long yet. |
|
Closing in favour of #212289. |
Mirror of https://gitlab.com/rycee/nmd/-/merge_requests/10
dummy://was added in Nix 2.4, but since we usepkgs.nixdirectly this is not an issue. https://nixos.org/manual/nix/unstable/release-notes/rl-2.4.html